Ignore convenience symlinks in glob expansion #22128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Configurability
illicitonion
force-pushed
the
globs-ignore-convenience-symlinks
branch
from
2fe8a50
to
a473312
Compare
illicitonion
changed the title
illicitonion
force-pushed
the
globs-ignore-convenience-symlinks
branch
from
a473312
to
e44f32a
Compare
illicitonion
force-pushed
the
globs-ignore-convenience-symlinks
branch
4 times, most recently
from
6f48362
to
39853d4
Compare
github-actions
bot
added
team-Performance
|
|
It's slightly unfortunate that this require moving symlink-related options to an options scope that applies to query (because query _also_ needs to know to ignore the symlinks when expanding globs). It's also slightly unfortunate that the behaviour of the symlink-related flags is really about _changing_ the existence of symlinks - the existence of the "ignore" value is somewhat problematic as it means that evaluation of globs may vary depending on the outcomes of previous builds' options, but this better (and more niche) than the current state which is that a first build and subsequent build with the _same_ options may give different results (because the first build may produce files in bazel-bin which are then picked up as inputs by the second build).
illicitonion
force-pushed
the
globs-ignore-convenience-symlinks
branch
from
39853d4
to
586f3e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's slightly unfortunate that this require moving symlink-related options to an options scope that applies to query (because query also needs to know to ignore the symlinks when expanding globs).
It's also slightly unfortunate that the behaviour of the symlink-related flags is really about changing the existence of symlinks - the existence of the "ignore" value is somewhat problematic as it means that evaluation of globs may vary depending on the outcomes of previous builds' options, but this better (and more niche) than the current state which is that a first build and subsequent build with the same options may give different results (because the first build may produce files in bazel-bin which are then picked up as inputs by the second build).
Fixes #11875