Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore convenience symlinks in glob expansion #22128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Apr 29, 2024

  1. Ignore convenience symlinks in glob expansion

    It's slightly unfortunate that this require moving symlink-related
    options to an options scope that applies to query (because query _also_
    needs to know to ignore the symlinks when expanding globs).
    
    It's also slightly unfortunate that the behaviour of the symlink-related
    flags is really about _changing_ the existence of symlinks - the
    existence of the "ignore" value is somewhat problematic as it means that
    evaluation of globs may vary depending on the outcomes of previous
    builds' options, but this better (and more niche) than the current state
    which is that a first build and subsequent build with the _same_ options
    may give different results (because the first build may produce files in
    bazel-bin which are then picked up as inputs by the second build).
    illicitonion committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    586f3e5 View commit details
    Browse the repository at this point in the history