go_proto_library: drop dependencies on APIv1 WKT packages #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 30, 2020 17:42
Since protobuf 3.14, the Well Known Types declare APIv2 package paths, which means generated code that imports them will import APIv2 packages. This PR is intended to be cherry-picked to the 0.23 and 0.24 release branches. It may slow down builds, since both APIv1 and APIv2 packages will be compiled; we can't tell which is needed during analysis. For bazelbuild#2721
These should not be imported in generated code when protobuf 3.14 or higher is used. protobuf 3.14.0 will be the minimum supported version for rules_go 0.25.0. Fixes bazelbuild#2721
|
Blocked by protocolbuffers/protobuf#8049. protoc 3.14.0 does not build on Windows with mingw64. I think this is a bug in protoc source, not mingw. |
|
@jayconrod Hi Jay! Google Ads is blocked by this. Can we by any chance prioritize this and merge it ASAP? |
|
@vam-google It looks like protocolbuffers/protobuf#8049 is still open. I can't do anything until that's fixed. Forcing protobuf 3.14 would break Windows cgo users. |
|
protocolbuffers/protobuf@aee143a was merged 3 days ago, FYI |
|
I think this is still blocked by a release of protoc that has it included. 3.15.0-rc1 doesn't have it, maybe 3.15.0 final will |
|
It's not mentioned in release notes, but v3.15.1 has protocolbuffers/protobuf#8286 included |
|
What's next on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should not be imported in generated code when protobuf 3.14 or
higher is used.
protobuf 3.14.0 will be the minimum supported version for rules_go 0.25.0.
For #2721
Fixes #2741