Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_proto_library: drop dependencies on APIv1 WKT packages #2740

Merged
merged 3 commits into from Jun 28, 2021
Merged

go_proto_library: drop dependencies on APIv1 WKT packages #2740

merged 3 commits into from Jun 28, 2021

Commits on Nov 30, 2020

  1. go_proto_library: add implicit dependencies on APIv2 packages 

    Since protobuf 3.14, the Well Known Types declare APIv2 package paths,
which means generated code that imports them will import APIv2
packages.

This PR is intended to be cherry-picked to the 0.23 and 0.24 release
branches. It may slow down builds, since both APIv1 and APIv2 packages
will be compiled; we can't tell which is needed during analysis.

For bazelbuild#2721
    Jay Conrod committed Nov 30, 2020
    Copy the full SHA
    69e0733 View commit details
    Browse the repository at this point in the history

  2. go_proto_library: drop dependencies on APIv1 WKT packages 

    These should not be imported in generated code when protobuf 3.14 or
higher is used.

protobuf 3.14.0 will be the minimum supported version for rules_go 0.25.0.

Fixes bazelbuild#2721
    Jay Conrod committed Nov 30, 2020
    Copy the full SHA
    98c2525 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Merge branch 'master' into upgrade-protobuf

    Jay Conrod committed Jun 28, 2021
    Copy the full SHA
    04d3c4f View commit details
    Browse the repository at this point in the history