Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update version of mkdirp #3266

Merged
merged 4 commits into from Mar 18, 2020
Merged

Update version of mkdirp #3266

merged 4 commits into from Mar 18, 2020

Conversation

j-pendlebury
Copy link
Contributor

@j-pendlebury j-pendlebury commented Mar 18, 2020

Part of #3268
Part of bbc/simorgh#5905

Overall change:
mkdirp had to be updated to pull in a new version of minimist because of a vulnerability.

Code changes:

  • Update mkdirp to 0.5.3, which pulls in minimist@1.2.5

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@j-pendlebury j-pendlebury added high priority ws-home Tasks for the WS Home Team ws-articles Tasks for the WS Articles Team dependencies Pull requests that update a dependency file ws-media The World Service media stream labels Mar 18, 2020
@j-pendlebury j-pendlebury self-assigned this Mar 18, 2020
@j-pendlebury j-pendlebury added this to PR in Progress in Simorgh via automation Mar 18, 2020
@j-pendlebury j-pendlebury moved this from PR in Progress to Code review in Simorgh Mar 18, 2020
Simorgh automation moved this from Code review to Ready for Test Mar 18, 2020
@PriyaKR
Copy link
Contributor

PriyaKR commented Mar 18, 2020

Dev dependency PRs doesn't require any testing from a tester.

@PriyaKR PriyaKR moved this from Ready for Test to Ready for merge (probably) in Simorgh Mar 18, 2020
@FK78 FK78 merged commit 775f151 into latest Mar 18, 2020
Simorgh automation moved this from Ready for merge (probably) to Done Mar 18, 2020
@j-pendlebury j-pendlebury deleted the update-mkdirp branch March 18, 2020 10:38
@j-pendlebury j-pendlebury restored the update-mkdirp branch March 18, 2020 10:38
@j-pendlebury j-pendlebury deleted the update-mkdirp branch March 18, 2020 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file high priority ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team ws-media The World Service media stream
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants