Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove npm audit whitelisted package - minimist #5905

Closed
1 task
j-pendlebury opened this issue Mar 17, 2020 · 0 comments · Fixed by #5976
Closed
1 task

Remove npm audit whitelisted package - minimist #5905

j-pendlebury opened this issue Mar 17, 2020 · 0 comments · Fixed by #5976
Assignees
@j-pendlebury
Labels
dependencies external blocked Blocked by an external dependency ws-articles Tasks for the WS Articles Team ws-media World Service Media
Projects
Simorgh

Comments

@j-pendlebury
Copy link
Contributor

j-pendlebury commented Mar 17, 2020 •
edited

Describe the bug
Similarly to #5814, we added minimist to the npm audit whitelist, since there are several packages that need to be updated.

Top Level Packages to be updated

  • @bbc/moment-timezone-include - Update version of mkdirp psammead#3266
  • @loadable/webpack-plugin
  • @storybook/react
  • babel-jest
  • babel-loader
  • bbc-a11y
  • brotli-webpack-plugin
  • chrome-launcher
  • compression-webpack-plugin
  • copy-webpack-plugin
  • cypress
  • eslint
  • jest-junit
  • jest
  • mocha-junit-reporter
  • mocha
  • storybook-chromatic
  • stylelint
  • terser-webpack-plugin
  • webpack-bundle-analyzer
  • webpack-dev-server
  • webpack

Full list here

Testing notes

  • This bug fix is expected to need manual testing.

Additional context
Add any other context about the problem here.
@j-pendlebury j-pendlebury added ws-articles Tasks for the WS Articles Team ws-home ws-media World Service Media dependencies labels Mar 17, 2020
@j-pendlebury j-pendlebury added this to To do in Simorgh via automation Mar 17, 2020
@j-pendlebury j-pendlebury self-assigned this Mar 17, 2020
@j-pendlebury j-pendlebury added the external blocked Blocked by an external dependency label Mar 17, 2020
@j-pendlebury j-pendlebury moved this from To do to Blocked (by something outside pod) in Simorgh Mar 17, 2020
This was referenced Mar 18, 2020
Merged
Closed
@j-pendlebury j-pendlebury mentioned this issue Mar 26, 2020
Merged
6 tasks
@j-pendlebury j-pendlebury moved this from Blocked (by something outside pod) to Issue in Progress in Simorgh Apr 2, 2020
@j-pendlebury j-pendlebury linked a pull request Apr 16, 2020 that will close this issue
Upgrade to the latest version of Cypress #5976
Merged
6 tasks
Simorgh automation moved this from Issue in Progress to Done Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j-pendlebury j-pendlebury

Labels
dependencies external blocked Blocked by an external dependency ws-articles Tasks for the WS Articles Team ws-media World Service Media
Projects
No open projects
Simorgh
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to the latest version of Cypress bbc/simorgh
1 participant
@j-pendlebury