Conversation
Frustratingly, EDIT: No worries, got a fix in the pipeline with the Electron team. |
Almost there! Minus the vendored LitElement code, this PR is currently I'm going to merge without removing some dead code so that I can also merge into the blue branch (which has modifications to some of the dead code). After merging, I'll make another PR that removes the dead code. |
👍 This PR is ready to go. Merging now! This won't fix the freezing issue. That's now being addressed with electron/electron#17221. We'll wait for that fix to land in electron to release a new Beaker with this PR. Any folks building from source, feel free to give the new master a try and let me know how this refactor works for you. Hopefully there aren't too many new bugs or regressions. |
In an effort to solve the freezing issue (#1333) I've decided to refactor Beaker to use the
BrowserView
API rather than<webview>
. This was a planned update already, but the freezing issue forced me to prioritize it. There will be other advantages to usability; most notably, devtools will be able to dock!Implementing this change is a pretty big undertaking. Because I can't render shell-window HTML on top of a
BrowserView
, I have to reimplement all modals and menus as sub-windows that float over the shell window. Given the magnitude of that change, I decided now would be a good time to reimplement basically all of the shell-window UI code (which was pretty crufty). That includes a switch from yo-yo to LitElement, which I've been getting great results from lately.Todo list:
updateHistory()
)shell-window:set-current-location
)Issues: