[Merged by Bors] - fix: explicitly specify required version of async-task #6509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Nov 7, 2022
james7132
approved these changes
Nov 7, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
# Objective Attempting to build `bevy_tasks` produces the following error: ``` error[E0599]: no method named `is_finished` found for struct `async_executor::Task` in the current scope --> /[...]]/bevy/crates/bevy_tasks/src/task.rs:51:16 | 51 | self.0.is_finished() | ^^^^^^^^^^^ method not found in `async_executor::Task<T>` ``` It looks like this was introduced along with `Task::is_finished`, which delegates to `async_task::Task::is_finished`. However, the latter was only introduced in `async-task` 4.2.0; `bevy_tasks` does not explicitly depend on `async-task` but on `async-executor` ^1.3.0, which in turn depends on `async-task` ^4.0.0. ## Solution Add an explicit dependency on `async-task` ^4.2.0.
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Attempting to build `bevy_tasks` produces the following error: ``` error[E0599]: no method named `is_finished` found for struct `async_executor::Task` in the current scope --> /[...]]/bevy/crates/bevy_tasks/src/task.rs:51:16 | 51 | self.0.is_finished() | ^^^^^^^^^^^ method not found in `async_executor::Task<T>` ``` It looks like this was introduced along with `Task::is_finished`, which delegates to `async_task::Task::is_finished`. However, the latter was only introduced in `async-task` 4.2.0; `bevy_tasks` does not explicitly depend on `async-task` but on `async-executor` ^1.3.0, which in turn depends on `async-task` ^4.0.0. ## Solution Add an explicit dependency on `async-task` ^4.2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Attempting to build
bevy_tasksproduces the following error:It looks like this was introduced along with
Task::is_finished, which delegates toasync_task::Task::is_finished. However, the latter was only introduced inasync-task4.2.0;bevy_tasksdoes not explicitly depend onasync-taskbut onasync-executor^1.3.0, which in turn depends onasync-task^4.0.0.Solution
Add an explicit dependency on
async-task^4.2.0.