Add image details and platform details in versions #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoMario109
force-pushed
the
add-platform-data-in-versions
branch
4 times, most recently
from
7606490
to
34f079b
Compare
| @@ -55,9 +55,7 @@ async def fetch_remote_tags(self, repository: str) -> List[str]: | |||
| data = await resp.json(content_type=None) | |||
| tags = data["results"] | |||
|
|
|||
| valid_images = [tag["name"] for tag in tags] | |||
| print(valid_images) | |||
There was a problem hiding this comment.
It would be nice if we could add a debug message like this one somewhere in the code
blueos_repository/consolidate.py
Outdated
| @dataclasses.dataclass | ||
| class Image: | ||
| digest: Optional[str] | ||
| size: int |
* Add for each version tag details about size and digest for each image * Add for each version tag details for active valid platforms specifications
JoaoMario109
force-pushed
the
add-platform-data-in-versions
branch
from
34f079b
to
5200c82
Compare
patrickelectric
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These details are needed for a cleaner implementation of the fix for bluerobotics/BlueOS#2109
These changes should add something like this in manifest.json