Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assets location #2311

Merged
merged 2 commits into from Mar 25, 2024
Merged

Fix assets location #2311

merged 2 commits into from Mar 25, 2024

Conversation

joaoantoniocardoso
Copy link
Collaborator

This fixes the following errors in the development env:

 cannot be imported from JavaScript.
Instead of /public/assets/vehicles/models/sub/SIMPLEROV_3.json, put the file in the src directory, and use /src/assets/vehicles/models/sub/SIMPLEROV_3.json instead.
Assets in public cannot be imported from JavaScript.
Instead of /public/assets/vehicles/models/sub/SIMPLEROV_4.json, put the file in the src directory, and use /src/assets/vehicles/models/sub/SIMPLEROV_4.json instead.
Assets in public cannot be imported from JavaScript.
Instead of /public/assets/vehicles/models/sub/VECTORED_6DOF.json, put the file in the src directory, and use /src/assets/vehicles/models/sub/VECTORED_6DOF.json instead.
Assets in public cannot be imported from JavaScript.
Instead of /public/assets/vehicles/models/sub/VECTORED.json, put the file in the src directory, and use /src/assets/vehicles/models/sub/VECTORED.json instead.
Assets in public cannot be imported from JavaScript.
Instead of /public/assets/vehicles/models/boat/UNDEFINED.glb, put the file in the src directory, and use /src/assets/vehicles/models/boat/UNDEFINED.glb instead.
Assets in public cannot be imported from JavaScript.
Instead of /public/assets/vehicles/models/rover/unknown.glb, put the file in the src directory, and use /src/assets/vehicles/models/rover/unknown.glb instead.
Assets in public cannot be imported from JavaScript.
Instead of /public/assets/vehicles/models/sub/SIMPLEROV_3.glb, put the file in the src directory, and use /src/assets/vehicles/models/sub/SIMPLEROV_3.glb instead.
Assets in public cannot be imported from JavaScript.
Instead of /public/assets/vehicles/models/sub/SIMPLEROV_4.glb, put the file in the src directory, and use /src/assets/vehicles/models/sub/SIMPLEROV_4.glb instead.
Assets in public cannot be imported from JavaScript.
Instead of /public/assets/vehicles/models/sub/SIMPLEROV_5.glb, put the file in the src directory, and use /src/assets/vehicles/models/sub/SIMPLEROV_5.glb instead.
Assets in public cannot be imported from JavaScript.
Instead of /public/assets/vehicles/models/sub/BLUEROV1.glb, put the file in the src directory, and use /src/assets/vehicles/models/sub/BLUEROV1.glb instead.
Assets in public cannot be imported from JavaScript.
Instead of /public/assets/vehicles/models/sub/VECTORED_6DOF.glb, put the file in the src directory, and use /src/assets/vehicles/models/sub/VECTORED_6DOF.glb instead.
Assets in public cannot be imported from JavaScript.
Instead of /public/assets/vehicles/models/sub/bluerov.glb, put the file in the src directory, and use /src/assets/vehicles/models/sub/bluerov.glb instead.
Assets in public cannot be imported from JavaScript.
Instead of /public/assets/vehicles/models/sub/VECTORED.glb, put the file in the src directory, and use /src/assets/vehicles/models/sub/VECTORED.glb instead.

@joaoantoniocardoso joaoantoniocardoso marked this pull request as draft January 16, 2024 23:12
@joaoantoniocardoso joaoantoniocardoso marked this pull request as ready for review February 7, 2024 21:21
@joaoantoniocardoso
core: frontend: Move assets from public to src
170473f 
Assets accessed by code should live in /src, not in /public
@joaoantoniocardoso joaoantoniocardoso added the merge-after-stable Should be merged only after next stable release label Mar 21, 2024
@patrickelectric patrickelectric merged commit 6f8580e into bluerobotics:master Mar 25, 2024
7 checks passed
@patrickelectric patrickelectric mentioned this pull request Mar 26, 2024
Closed
@patrickelectric patrickelectric mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

Assignees
No one assigned
Labels
merge-after-stable Should be merged only after next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joaoantoniocardoso @patrickelectric