Add first calibration abstraction #2339
Conversation
patrickelectric
commented
Jan 24, 2024
•
patrickelectric
commented
patrickelectric
force-pushed
the
baro_and_others
branch
from
a608f5a
to
d04a672
Compare
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
baro_and_others
branch
from
f531854
to
eefbd5e
Compare
patrickelectric
force-pushed
the
baro_and_others
branch
from
eefbd5e
to
ecdd039
Compare
patrickelectric
force-pushed
the
baro_and_others
branch
from
ecdd039
to
dd98a6c
Compare
| Status | ||
| </th> | ||
| <th class="text-left"> | ||
| Calibrate |
There was a problem hiding this comment.
| Calibrate | |
| Calibrated at |
| private calibrationStatus: MavResult | undefined | ||
|
|
||
| constructor() { | ||
| mavlink2rest.startListening(MAVLinkType.COMMAND_ACK).setCallback((content) => { |
There was a problem hiding this comment.
can we make it so this listener only lives while the calibration is being done?
start it at start() and discard() it when the calibration is successful/fails
There was a problem hiding this comment.
This is mostly a free websocket, it's handle by the server where it only sends the messages that match the regex. Since it's registered to COMMAND_ACK, it should have no performance impact.
patrickelectric
force-pushed
the
baro_and_others
branch
from
dd98a6c
to
5cd5351
Compare
patrickelectric
added
the
merge-after-stable
Codewise is not possible, be sure to open in an anonymous tab. |
| for (const barometer of this.baros) { | ||
| // BARO_SPEC_GRAV Only exist for underwater vehicles | ||
| const spec_gravity_param = autopilot_data.parameter('BARO_SPEC_GRAV') | ||
| results[barometer.param] = printParam(spec_gravity_param) ?? 'Barometric' |
There was a problem hiding this comment.
printParam returns "Unknown" as a string if the parameter is undefined:
https://github.com/bluerobotics/BlueOS/blob/master/core/frontend/src/types/autopilot/parameter.ts#L44
patrickelectric
force-pushed
the
baro_and_others
branch
from
6874bc4
to
92e81f6
Compare
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
baro_and_others
branch
from
92e81f6
to
20ef8ff
Compare
|
ping @Williangalvani |
