Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wizard] Fix return button #2416

Merged
merged 3 commits into from Mar 22, 2024
Merged

[Wizard] Fix return button #2416

merged 3 commits into from Mar 22, 2024

Conversation

joaoantoniocardoso
Copy link
Collaborator

closes #2415

@joaoantoniocardoso joaoantoniocardoso changed the title Wizard review Fix return button Feb 26, 2024
@joaoantoniocardoso joaoantoniocardoso changed the title Fix return button [Wizard] Fix return button Feb 26, 2024
patrickelectric
patrickelectric requested changes Feb 27, 2024
View reviewed changes
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to be not working.
The third has a missing prefix (core: frontend:...).
Peek 2024-02-27 08-34

@Williangalvani
Copy link
Member

Williangalvani commented Feb 27, 2024 •
edited

It appears to be not working. The third has a missing prefix (core: frontend:...). ![Peek 2024-02-27 08-34]

my god what is happening to your computer?

@joaoantoniocardoso
Copy link
Collaborator Author

@patrickelectric can you check again? It is working here:

return_is_working.mp4

@joaoantoniocardoso
Copy link
Collaborator Author

ping @patrickelectric

@patrickelectric patrickelectric merged commit 19c84a5 into bluerobotics:master Mar 22, 2024
6 checks passed
@joaoantoniocardoso joaoantoniocardoso deleted the wizard_review branch March 22, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wizard: Return button (on step 3) is going back to step 1 instead of previous step
3 participants
@joaoantoniocardoso @Williangalvani @patrickelectric