Enhancement Network Connection Detection in BeaconTray #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update wireless diagnostic in VideoDiagnoticHelper to be consice as the way BeaconTray does, removing cases where unknown interfaces are classified as Wireless
* Updat BeaconTrayMenu to consider cases where a unknown network is listed to avoid cases where interfaces are classified mistakenly
JoaoMario109
requested review from
Williangalvani,
patrickelectric and
joaoantoniocardoso
and removed request for
Williangalvani
patrickelectric
approved these changes
Mar 12, 2024
patrickelectric
added
the
merge-after-stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update enhances how BeaconTrayMenu reports the connection methods to BlueOS, introducing proper report for unknown interfaces and adding USB as a recognized type, reflecting beacon's expanded listings.
Related to #2198