core: Dockerfile: Enforce style for git version #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
requested review from
Williangalvani,
joaoantoniocardoso and
JoaoMario109
joaoantoniocardoso
approved these changes
Mar 14, 2024
patrickelectric
added
the
merge-after-stable
core/Dockerfile
Outdated
| ARG GIT_DESCRIBE_TAGS | ||
| RUN [ -z "$GIT_DESCRIBE_TAGS" ] \ | ||
| && echo "GIT_DESCRIBE_TAGS argument not provided." \ | ||
| && echo "Use: --build-arg GIT_DESCRIBE_TAGS=\$(git describe --tags --long --always)" \ | ||
| && exit 1 \ | ||
| || [[ ! $GIT_DESCRIBE_TAGS =~ -[0-9]+-g[a-f0-9]{8}$ ]] \ |
There was a problem hiding this comment.
Maybe change this line to something like this, since /bin/sh will not support the [[ ]] and docker usually uses /bin/sh, at least in my machine didn't worked without invoking bash
Suggested change
| || [[ ! $GIT_DESCRIBE_TAGS =~ -[0-9]+-g[a-f0-9]{8}$ ]] \ | |
| || /bin/bash -c "[[ ! $GIT_DESCRIBE_TAGS =~ -[0-9]+-g[a-f0-9]{8}$ ]]" \ |
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…P_GIT_DESCRIBE This avoid building the entire docker if building locally for tests Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
add_test
branch
from
810d9f6
to
7f19e3b
Compare
|
ping @JoaoMario109 |
JoaoMario109
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2435