Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flickering problem in NMEA injector page #2452

Merged
merged 2 commits into from Mar 25, 2024

Conversation

JoaoMario109
Copy link
Contributor

This add a delay logic to avoid fast appearances from the loading component causing a flickering on the UI

Fixes #2422

* Add option to set a dispose target to be tracked togheter with the
  OneMoreTime object itself, in case any of, OneMoreTime instance or
  disposeWith instance got disposed, both will cause the stop of the
  loop
* Add a delay logic to avoid fast rerenders of loading component when
  loading times are close to zero
@patrickelectric patrickelectric added the merge-after-stable Should be merged only after next stable release label Mar 14, 2024
@patrickelectric patrickelectric merged commit d1e52f2 into bluerobotics:master Mar 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-after-stable Should be merged only after next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: NMEA page is flickering
2 participants