Correct parameters name in ParameterLoader #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoMario109
force-pushed
the
2447-show-parameters-names
branch
from
ed7603f
to
a2be4e6
Compare
JoaoMario109
requested review from
patrickelectric,
Williangalvani and
joaoantoniocardoso
| const paramValueText = printParam(parameter) | ||
| const paramUnitsText = parameter?.units ? `[${parameter.units}]` : '' | ||
|
|
||
| return paramValueText + paramUnitsText |
There was a problem hiding this comment.
Suggested change
| return paramValueText + paramUnitsText | |
| return paramValueText + ' ' + paramUnitsText |
I don't remember the correct syntax, but the idea is to have something like "10 [A]" instead of "10[A]".
edit: it might be better to just prepend a space on the paramUnitsText, otherwise we would have a space appended to the strings that don't have units.
I used this way to keep concise with the already existing implementation in But is actually easy to change if you guys think its better |
patrickelectric
approved these changes
Mar 25, 2024
|
@JoaoMario109 can you rebase over master ? |
* Change to use correct parameters values and units instead of just showing the raw enum value
JoaoMario109
force-pushed
the
2447-show-parameters-names
branch
from
a2be4e6
to
7ed4ce2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to use correct parameters values and units instead of just showing the raw enumeration value
Closes #2447