Add loading state to video table #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
force-pushed
the
add-loading-video-table
branch
from
e1faa30
to
22a94e7
Compare
patrickelectric
approved these changes
Mar 8, 2024
patrickelectric
requested changes
Mar 8, 2024
There was a problem hiding this comment.
Jus to be sure, is supposed to the lock file to be added on d111b1f ?
patrickelectric
approved these changes
Mar 8, 2024
This way users don't receive a "no videos available" warn when it's in fact loading the database.
rafaellehmkuhl
force-pushed
the
add-loading-video-table
branch
from
22a94e7
to
c771cbb
Compare
|
Rebased over master without changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, users don't receive a "no videos available" warn when it's in fact loading the database.
Screen.Recording.2024-03-06.at.16.27.23.mov
To be added after #809.