Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

views: WidgetsView: Use AsyncComponentLoader over if test #836

Merged
merged 1 commit into from Mar 22, 2024
Merged

views: WidgetsView: Use AsyncComponentLoader over if test #836

merged 1 commit into from Mar 22, 2024

Conversation

patrickelectric
Copy link
Member

Move away from if test to AsyncComponentLoader

@patrickelectric
views: WidgetsView: Use AsyncComponentLoader over if test
0bc7c72 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
JoaoMario109
JoaoMario109 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@JoaoMario109 JoaoMario109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add some error handling when trying to dynamically import the component in case the file is remove, but in normal operation shouldn't be a problem and the error will not block the rest of the UI

@patrickelectric patrickelectric merged commit c78cd8b into bluerobotics:master Mar 22, 2024
7 checks passed
@patrickelectric patrickelectric mentioned this pull request Mar 22, 2024
Merged
@rafaellehmkuhl
Copy link
Member

Nice addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoMario109 JoaoMario109 JoaoMario109 approved these changes

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

@joaoantoniocardoso joaoantoniocardoso Awaiting requested review from joaoantoniocardoso

@ArturoManzoli ArturoManzoli Awaiting requested review from ArturoManzoli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrickelectric @rafaellehmkuhl @JoaoMario109