Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTP receiver jitter buffer target configuration #941

Conversation

joaoantoniocardoso
Copy link
Contributor

@joaoantoniocardoso joaoantoniocardoso commented May 9, 2024

This patch allows us to control the RTP receiver target jitter buffer.

The default value is set to zero, which gives us the minimum possible latency for the stream.

From my tests, setting it to zero improved latency compared to the browser's default (unbeknownst to me).

image

@joaoantoniocardoso
Copy link
Contributor Author

Here is a video showing it working on Cockpit. Unfortunately, the changes are not being applied reactively (help me?), only after a refresh:

cockpit_jitter_buffer_config.mp4

@joaoantoniocardoso joaoantoniocardoso force-pushed the add_rtp_receiver_jitter_buffer_target_configuration branch from fe9db60 to bd98868 Compare May 9, 2024 15:01
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
What are the practical implications of this change?
I see that in "auto" the latency seems lower than in 0, right? Do we have a lower chance of stuttering with 0?

About the reactivity, from what I'm looking it won't work if we don't change a lot of other references on the composable itself, so I would suggest leaving at it is for now, or adding a "save" button which reloads the application after the change of this value.

@joaoantoniocardoso
Copy link
Contributor Author

joaoantoniocardoso commented May 9, 2024

Nice! What are the practical implications of this change? I see that in "auto" the latency seems lower than in 0, right? Do we have a lower chance of stuttering with 0?

About the reactivity, from what I'm looking it won't work if we don't change a lot of other references on the composable itself, so I would suggest leaving at it is for now, or adding a "save" button which reloads the application after the change of this value.

Oh, on the contrary, the 0 has lower latency than null (auto). The video compares the latencies with a GStreamer UDP, and because it is not running concurrently, it might not seem much different from null to 0, but I have tested it on the MCM development interface.

@rafaellehmkuhl rafaellehmkuhl merged commit 82987ff into bluerobotics:master May 9, 2024
8 checks passed
@joaoantoniocardoso joaoantoniocardoso deleted the add_rtp_receiver_jitter_buffer_target_configuration branch May 9, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants