Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: cpp: Add further instructions #66

Merged

Conversation

RaulTrombin
Copy link
Member

No description provided.

@RaulTrombin RaulTrombin changed the title examples: cpp: Add furthuer instructions examples: cpp: Add further instructions Mar 1, 2024
@@ -1,5 +1,21 @@
# How to build
# How to use
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me, they are still build instructions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add more instructions here,
such create&use a container that cross-compile it

And follow the same title as Python instruction: https://github.com/bluerobotics/navigator-lib/blob/master/examples/python/README.md

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that the title of the 'Python instructions' document is not great, and in the future, if you add a "create&use a container that cross-compile it" instruction, you would need to create a different subsection anyway, then change the title when it makes sense.

@patrickelectric patrickelectric merged commit 74cdbd6 into bluerobotics:master Mar 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants