#5062 JVM Crash in bndtools explorer #5411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was able to consistently crash the VM by selecting a binary class file in rt.jar from the VM project item and then closing the VM project item. After hundreds of trials I found that the bug was triggered when the getTreeViewer().refresh() was called during a model update. For the record, this happened on the main thread so I cannot see any issue with this. I then made the refresh conditional on a change in the filter text field. For this, an AtomicBoolean dirtyFilter was added. This seemed to work fine now. Of course this does not remove the bug. There is an SWT bug lurking but closing an tree item in the bnd explorer will no longer trigger it. Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to consistently crash the VM by
selecting a binary class file in rt.jar from
the VM project item and then closing the VM project item.
After hundreds of trials I found that the bug was
triggered when the getTreeViewer().refresh() was
called during a model update. For the record,
this happened on the main thread so I cannot
see any issue with this.
I then made the refresh conditional on a change
in the filter text field. For this, an
AtomicBoolean dirtyFilter was added.
This seemed to work fine now.
Of course this does not remove the bug. There
is an SWT bug lurking but closing an tree item
in the bnd explorer will no longer trigger it.
Fixes #5062
Signed-off-by: Peter Kriens Peter.Kriens@aqute.biz