Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5062 JVM Crash in bndtools explorer #5411

Merged
merged 1 commit into from Nov 3, 2022
Merged

Commits on Nov 3, 2022

  1. bndtools#5062 JVM Crash in bndtools explorer

    I was able to consistently crash the VM by
    selecting a binary class file in rt.jar from
    the VM project item and then closing the VM project
    item.
    
    After hundreds of trials I found that the bug was
    triggered when the getTreeViewer().refresh() was
    called during a model update. For the record,
    this happened on the main thread so I cannot
    see any issue with this.
    
    I then made the refresh conditional on a change
    in the filter text field. For this, an
    AtomicBoolean dirtyFilter was added.
    
    This seemed to work fine now.
    
    Of course this does not remove the bug. There
    is an SWT bug lurking but closing an tree item
    in the bnd explorer will no longer trigger it.
    
    
    
    Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
    pkriens committed Nov 3, 2022
    Copy the full SHA
    9158037 View commit details
    Browse the repository at this point in the history