feat(BDropdown)!: replace "container" prop with "teleportTo" #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
VividLemon
commented
Mar 10, 2024
packages/bootstrap-vue-next/src/components/BAccordion/BAccordion.vue
Outdated
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/components/BFormRadio/BFormRadio.vue
Outdated
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/components/BFormRadio/BFormRadioGroup.vue
Outdated
Show resolved
Hide resolved
|
If you don't have time to fix the PR, I could do it. Let me know if you need my help, @VividLemon |
Fixing the broken tests would be a big help. Tyvm |
|
@anrolmar On second thought, I would prefer if you did not attempt to fix my branch. There are some things I want to change about the implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(BDropdown): add teleportDisabled prop
feat(BPopover)!: replace "container" prop with "teleportTo"
feat(BPopover): add teleportDisabled prop
feat: export component prop types
refactor: use defineModel > useVModel fixes #1799
fix(generics): use generic constraints for BTable & BTableLite
refactor: move all props into ComponentProps.ts -> export types & for future global options overhaul
Describe the PR
A clear and concise description of what the pull request does.
Small replication
A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied