Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Ask for Insights on first run." breaks automation. #1102

Closed
tthew opened this issue Feb 6, 2014 · 87 comments
Closed

"Ask for Insights on first run." breaks automation. #1102

tthew opened this issue Feb 6, 2014 · 87 comments

Comments

@tthew
Copy link

tthew commented Feb 6, 2014

When issuing bower install for the first time even with the -s option present bower asks 'May bower anonymously report usage statistics to improve the tool over time? (Y/n)' which breaks automated tools not expecting interaction (i.e. Travis).

Would be great if we could provide an answer as a part of the command or at least for the -s option to be respected.

@tthew
Copy link
Author

tthew commented Feb 6, 2014

Obviously, we can do something like yes no | bower install but it's a bit hacky.

@sindresorhus
Copy link
Contributor

Agreed. Silent should be silent.

aeby pushed a commit to atizo/braindump that referenced this issue Feb 13, 2014
@gergelyke
Copy link
Contributor

👍

1 similar comment
@mex
Copy link
Contributor

mex commented Mar 11, 2014

👍

@alfonsomartinde
Copy link

👍

Using worker: worker-linux-9-1.bb.travis-ci.org:travis-linux-14

may-bower

@gergelyke
Copy link
Contributor

try @oroce's solution:
bower install | xargs echo
should work

@gergelyke
Copy link
Contributor

Or use bower@1.2 :)

@mylescc
Copy link

mylescc commented Mar 11, 2014

👍 This is causing issues with my codeship build as well.

@hemanth
Copy link
Contributor

hemanth commented Mar 11, 2014

@alfonsomartinde
Copy link

@gergelyke:

bower install | xargs echo

Solves the problem :-) Thanks!!

dyurkavets pushed a commit to EdmundsWidgets/com.edmunds.widgets that referenced this issue Mar 11, 2014
@arcreative
Copy link

I don't think bower install -s is viable here... We shouldn't be forced to use a silent option with an automation tool just to keep it from asking us questions in build environments. I would say make this an opt-in(preferable) or opt-out in .bowerrc.

jridgewell added a commit to jridgewell/minionette that referenced this issue Mar 11, 2014
@jridgewell
Copy link

This must be an opt-in. Releasing this feature just broke thousands of travis build scripts.

kostia added a commit to kostia/jquery.li18n that referenced this issue Mar 11, 2014
@jridgewell
Copy link

For reference, the CHANGELOG recommends using --config.interactive=false for automated scripts.

@DavidBoike
Copy link

<sarcasm>Oh that's great that the changelog mentions that. Totally makes up for a huge breaking change on a 0.1 version bump release.</sarcasm>

@rayshan
Copy link
Member

rayshan commented Apr 2, 2014

Rolling insight out is a little painful but please hang in there, in the long run stats will be very beneficial to the community (think dashboard and API to query per-package stats #1164 (comment))

@jokeyrhyme
Copy link

Is there a command we can run to manually opt-in when (or just after) we first install bower? That would be my preference, to make one change right at the beginning instead of having to change every single automated script I have.

@jameshfisher
Copy link

Can we please add --config.interactive=false to the documentation/help?

@stuartpb
Copy link

I would really prefer this to be manually opt-in rather than opt-out.

Bower, like any other tool, should play nicely with automation (in any form): for example, we're using it on a build server, where setting a "CI" variable would be a touch inaccurate.

I think an acceptable style to copy would be Git's behavior in 1.8 and 1.9 when the default push mode is unset: print a warning that the mode is unset, and give the commands that should be used to opt in or explicitly opt out, but don't halt the entire thread of execution over it.

@stuartpb
Copy link

Also, behaviors like this are leading us to strongly consider abandoning Bower altogether in favor of just vendoring scripts into the tree manually. We don't have time for tools that expect to be babysat.

@arcreative
Copy link

@thanpolas Thanks for being so polite/constructive and chasing away the only maintainer that was willing to help us with this. I'm glad you seem to be so clear on the open source process--didn't realize it entailed being an arrogant ass about everything. I'll be sure to employ this tactic in the future, since it seems to work so well for you.

His suggestion was to SUBMIT A PR for it, not insult him until he created a PR for you.

@mex
Copy link
Contributor

mex commented Sep 18, 2015

Maybe we can end this discussion with this: #1923

This both adds a check for process.env.CI and adds a fallback on 30 sec, if no response is given to the prompt.

@thanpolas
Copy link

@arcreative i'm afraid you got it all backwards. Bower is not reliant on a single entity, here's where open source comes in. If the issue is the PR i'd gladly submit it myself.

The problem here is that Team Bower would not accept such a PR.

If that's not the case, then mea culpa and i'll promptly submit a PR ripping off the whole analytics system from its roots.

@waynebloss
Copy link

I like the idea of just removing analytics altogether because nobody here voiced any real need for them to be collected in the first place.

The only purpose that I could gather is that they're needed for some website that we're not sure if anyone is using.

@waynebloss
Copy link

Adding a timeout to "fix" this problem seems like a terrible idea. Could someone please explain to me why we need these analytics so badly?

Why not just make this thing truly opt-in by removing the prompt altogether?

@sheerun
Copy link
Contributor

sheerun commented Sep 19, 2015

I don't like the way @thanpolas behaves in this thread, but here is my proposal anyway:

Personally, I agree that:

  • Most of the command statistics (except maybe install counts) are not useful
  • "Top packages" is of questionable use too, because installs are counted only install directly, like bower install jquery. They don't show total download/star count for modules. Ideally they should show trending repositories within packages registered in Bower registry (something like https://github.com/explore)
  • "Popularity around the world" section seems not useful as well

I think we need http://bower.io/stats/ to show that bower is still alive (for example to show what versions of bower are still installed and used), and to show pulse of packages registered in bower registry (for example show "Top 50 starred repositories in last 7 days)").

Because most of packages in Bower's public registry come from GitHub, I think we could remove analytics from Bower if we could retrieve following counts:

  • npm installs of bower, per version
  • daily number of new stars for each "component" registered in bower

And re-implement http://bower.io/stats using these statistics

I hope core team agrees with it and I hope someone will donate his/her time to make it happen :)

@sheerun sheerun reopened this Sep 19, 2015
@sheerun
Copy link
Contributor

sheerun commented Sep 19, 2015

Of course if the things I mentioned are done, we'd remove analytics from Bower, completely.

stuartpb added a commit to stuartpb/github-drama that referenced this issue Sep 21, 2015
nikolas added a commit to nikolas/github-drama that referenced this issue Sep 24, 2015
posita referenced this issue in vivekbarsagadey/posita Sep 30, 2015
sheerun added a commit that referenced this issue Jan 19, 2016
They caused more issues than useful they were.

Instead, we'll focus on fetching statistics from
NPM registry to watch Bower's popularity, and
GitHub stars over time to watch packages' popularity.
@sheerun sheerun self-assigned this Jan 19, 2016
@samccone
Copy link
Member

Can everyone on the thread make sure to treat other people working on this with respect, I am pretty ashamed at the level of discourse on this issue.

I know it is easy to talk down and shame people, but honest mistakes are made in software.

Unless you are going to help please try and be positive, and thank @sheerun for donating his time to fix this.

Thanks you @sheerun !!!

@sheerun
Copy link
Contributor

sheerun commented Jan 19, 2016

We need to wait for @npm to publish per-version download counts (it's extremely useful statistic for any package owner, it's shame it's not available), but otherwise http://bower.io/stats is updated and #1102 ready to merge.

sheerun added a commit that referenced this issue Jan 20, 2016
Remove analytics from Bower, fixes #1102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests