Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use --non-interactive when running svn client #1969

Merged
merged 1 commit into from Oct 24, 2015
Merged

use --non-interactive when running svn client #1969

merged 1 commit into from Oct 24, 2015

Conversation

hojt
Copy link
Contributor

@hojt hojt commented Oct 23, 2015

Prevents svn CLI client to hang forever with no feedback to the user, upon any server connection errors that request user input. Fixes #1968

@hojt
Copy link
Contributor Author

hojt commented Oct 23, 2015

Any way to re-run the CI build? Seems it is failing for an unrelated reason.

If there is a problem in connecting to the Subversion server,
e.g. credential or certificate related, the CLI client will pause to
ask the user for input on the console. This is not handled by bower
Subversion Resolver, causing the install process to hang forever
with no message printed to the bower user.

Running the Subversion CLI client with the option --non-interactive
will instead cause the client to exit upon such an error.This is
detected by the bower resolver and the message printed to the user,
making it much easier to investigate and solve the underlying problem.
@hojt
Copy link
Contributor Author

hojt commented Oct 23, 2015

Aha! Updating the commit comment triggered a new CI build. :)

@sheerun
Copy link
Contributor

sheerun commented Oct 24, 2015

Thanks!

sheerun added a commit that referenced this pull request Oct 24, 2015
use --non-interactive when running svn client
@sheerun sheerun merged commit 8f0a3d7 into bower:master Oct 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants