Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to pass through idle_in_transaction_session_tim… #2049

Merged
merged 4 commits into from Dec 29, 2019
Merged

Adding ability to pass through idle_in_transaction_session_tim… #2049

merged 4 commits into from Dec 29, 2019

Conversation

aheuermann
Copy link
Contributor

…eout

Allowing for passing in the idle_in_transaction_session_timeout option.

@aheuermann aheuermann force-pushed the idle_in_transaction_session_timeout branch from ce7d7a8 to 26a6f2b Compare December 27, 2019 21:24
brianc
brianc approved these changes Dec 27, 2019
View reviewed changes
Copy link
Owner

@brianc brianc left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks great - good tests! Thanks for the PR, I'll get this released today or tomorrow!

brianc
brianc reviewed Dec 27, 2019
View reviewed changes
packages/pg/lib/defaults.js Outdated Show resolved Hide resolved
@aheuermann aheuermann force-pushed the idle_in_transaction_session_timeout branch from 26a6f2b to bb8e806 Compare December 27, 2019 21:31
@aheuermann aheuermann force-pushed the idle_in_transaction_session_timeout branch from 3169ffc to 6363778 Compare December 27, 2019 22:05
@aheuermann
Copy link
Contributor Author

Note: it looks like idle_in_transaction_session_timeout at the client-level was added in v10, is there a simple way to disable the tests for all versions < v10?

@brianc
Copy link
Owner

brianc commented Dec 27, 2019

no rush here - code changes look good...I'll merge it once the tests pass. 👍

@aheuermann aheuermann force-pushed the idle_in_transaction_session_timeout branch from 46f0113 to 8390432 Compare December 28, 2019 15:02
@brianc brianc merged commit 6b39253 into brianc:master Dec 29, 2019
@brianc
Copy link
Owner

brianc commented Dec 29, 2019

published with pg@7.17.0 - thanks!

@aheuermann aheuermann mentioned this pull request Dec 29, 2019
Merged
6 tasks
pankleks added a commit to pankleks/DefinitelyTyped that referenced this pull request Mar 12, 2020
@pankleks
add idle_in_transaction_session_timeout
3615585 
related to: brianc/node-postgres#2049
@pankleks pankleks mentioned this pull request Mar 12, 2020
Merged
rbuckton pushed a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Mar 14, 2020
@pankleks
add idle_in_transaction_session_timeout (#43089)
5944184 
related to: brianc/node-postgres#2049
@legopin legopin mentioned this pull request Oct 16, 2020
Closed
@mriedem mriedem mentioned this pull request Oct 16, 2020
Merged
@pSnehanshu
Copy link

This is confusing, there's also a idle_in_transaction_session_timeout parameter available in Postgres. Does it override that value at the connection level, or is this handled at pg level?

@charmander
Copy link
Collaborator

charmander commented Oct 27, 2022 •
edited

there's also a idle_in_transaction_session_timeout parameter available in Postgres

@pSnehanshu That is exactly what this option sets for a connection, and nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianc brianc brianc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aheuermann @brianc @pSnehanshu @charmander