Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the node version in package.json #1793

Merged
merged 1 commit into from Jan 4, 2018
Merged

Set the node version in package.json #1793

merged 1 commit into from Jan 4, 2018

Conversation

TehShrike
Copy link
Contributor

Testing against 0.10 and 0.12 was dropped in e8dbe6c

@TehShrike
Set the node version in package.json
89fab44 
Testing against 0.10 and 0.12 was dropped in e8dbe6c
@TehShrike TehShrike mentioned this pull request Jan 4, 2018
Closed
goto-bus-stop
goto-bus-stop approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. would you like to handle the release too?

@TehShrike
Copy link
Contributor Author

I'm down. 👍

I know that whether or not dropping support for insecure versions of node should be a breaking change is a contentious topic, do you feel this should be a breaking or feature version bump?

Personally I tend towards breaking releases if dropping support for versions of node that are in maintenance, and feature/patch for dropping support for versions of node that are out of LTS, but I don't have strong opinions.

@goto-bus-stop
Copy link
Member

i think we should follow module-deps & detective and do a major bump :)

@bcomnes
Copy link
Member

bcomnes commented Jan 4, 2018

Just make sure to update module-deps before doing the bump!

@TehShrike
Copy link
Contributor Author

The module-deps dependency got bumped in #1785, so it should be good to go.

Do y'all prefer having pull requests opened for changelog additions, or is it fine if I push changelog+package.json straight into master when publishing?

@goto-bus-stop
Copy link
Member

just pushing straight to master is how i've done it, so i'm cool w/ that!

@TehShrike TehShrike merged commit a9aaa99 into browserify:master Jan 4, 2018
ljharb added a commit to ljharb/browserify that referenced this pull request Jan 6, 2018
@ljharb
Set engines back to 0.8 (reverts browserify#1793)
46410c2
ljharb added a commit to ljharb/browserify that referenced this pull request Jan 7, 2018
@ljharb
Set engines back to 0.8 (reverts browserify#1793)
a522c43
This was referenced Jun 1, 2021
Merged
Open
Open
Open
Open
Open
Open
Open
@renovate renovate bot mentioned this pull request Jun 14, 2021
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jul 5, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Jul 8, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TehShrike @goto-bus-stop @bcomnes