[PLAT-12017] lodash.template | CVE-2021-23337 #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
force-pushed
the
PLAT-12017/override-lodash-template
branch
from
e61be15
to
f5f3679
Compare
Draft
djskinner
approved these changes
May 21, 2024
I've never seen that before, actually! it might be possible to do with dependabot but I don't think we've got it configured that way. I tend to have to merge these and wait for the next scan to close off the ticket. but I've confirmed using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Manually override
@lerna/conventional-commitsto remove vulnerablelodash.templatepackage, resolving CVE-2021-23337Design
Ideally, we should update the major version of lerna to resolve this and additional security vulnerabilities, but this requires additional work around CI pipelines and is out of scope for this PR.