Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(rxjs): updating rxjs to v7 #1350

Merged
merged 5 commits into from
Nov 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
58 changes: 47 additions & 11 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"imask": "^6.2.2",
"novo-design-tokens": "^1.0.0-beta.6",
"post-robot": "9.0.30",
"rxjs": "~6.5.5",
"rxjs": "^7.5.4",
"text-mask-addons": "^3.8.0",
"timezone-support": "^2.0.2",
"tslib": "^2.0.0",
Expand Down
4 changes: 2 additions & 2 deletions projects/elements/components/card/card.ts
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,9 @@ export class CardElement implements OnChanges, OnInit {
}

@Output()
onClose: EventEmitter<any> = new EventEmitter();
onClose: EventEmitter<void> = new EventEmitter();
@Output()
onRefresh: EventEmitter<any> = new EventEmitter();
onRefresh: EventEmitter<void> = new EventEmitter();

cardAutomationId: string;
labels: NovoLabelService;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export class NovoDataTablePagination<T> implements OnInit, OnDestroy {
@Input()
public errorLoading: boolean = false;
@Input()
public paginationRefreshSubject = new Subject();
public paginationRefreshSubject = new Subject<void>();

@Input()
get length(): number {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ import { NovoDataTableFilterUtils } from '../services/data-table-filter-utils';

@Injectable()
export class DataTableState<T> {
public selectionSource = new Subject();
public selectionSource = new Subject<void>();
public paginationSource = new Subject();
public sortFilterSource = new Subject();
public resetSource = new Subject();
public resetSource = new Subject<void>();
public expandSource = new Subject();
public allMatchingSelectedSource = new Subject();
public dataLoaded = new Subject();
public dataLoaded = new Subject<void>();
public dataLoadingSource = new Subject();

sort: IDataTableSort = undefined;
Expand Down
2 changes: 1 addition & 1 deletion projects/elements/components/field/field.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export class NovoFieldElement implements AfterContentInit, OnDestroy {
private _destroyed = new Subject<void>();

@Output() valueChanges: EventEmitter<any> = new EventEmitter();
@Output() stateChanges: EventEmitter<any> = new EventEmitter();
@Output() stateChanges: EventEmitter<void> = new EventEmitter();

constructor(public _elementRef: ElementRef, private _changeDetectorRef: ChangeDetectorRef) {}
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export class DataTableRemoteExample {
value: 'asc',
};
public globalSearchEnabled: boolean = false;
public refreshSubject: Subject<boolean> = new Subject();
public refreshSubject: Subject<void> = new Subject();

// Remote configuration
public remoteService: RemoteDataTableService<MockData>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ export class DataTableRowsExample {
value: 'asc',
};
public globalSearchEnabled: boolean = false;
public refreshSubject: Subject<boolean> = new Subject();
public refreshSubject: Subject<void> = new Subject();

// Basic configuration
public basicRows: MockData[];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ export class DataTableServiceExample {
value: 'asc',
};
public globalSearchEnabled: boolean = false;
public refreshSubject: Subject<boolean> = new Subject();
public refreshSubject: Subject<void> = new Subject();

// Basic configuration
public basicService: IDataTableService<MockData>;
Expand Down