Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(rxjs): updating rxjs to v7 #1350

Merged
merged 5 commits into from Nov 8, 2022
Merged

build(rxjs): updating rxjs to v7 #1350

merged 5 commits into from Nov 8, 2022

Conversation

dvoegelin
Copy link
Collaborator

@dvoegelin dvoegelin commented Sep 8, 2022

Description

updated rxjs from v6 to v7.5.4 due to alleged huge performance increase.
https://twitter.com/benlesh/status/1491544862403006464

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

@dvoegelin dvoegelin self-assigned this Sep 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Visit the preview URL for this PR (updated for commit 45446d2):

https://novo-elements--pr1350-rxjs-v7-llvgk2dg.web.app

(expires Thu, 15 Sep 2022 20:21:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Visit the preview URL for this PR (updated for commit 598acab):

https://novo-elements--pr1350-rxjs-v7-tnvrxbkg.web.app

(expires Tue, 15 Nov 2022 17:06:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

@dvoegelin dvoegelin changed the base branch from next to beta November 4, 2022 17:47
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

$GITHUB_STEP_SUMMARY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant