Terminal does not display command after go-prompt exit #228

mrpre · 2021-04-09T05:33:13Z

Bug reports

After go-prompt exit the BASH doesn't show what I have inputed.

It's All ok when go-prompt doesn't been run.

input: date + enter

[root /ctl]
$date
Fri Apr  9 11:49:41 CST 2021

[root /ctl]
$./ctl ops
>>> exit
Bye!

After go-prompt run, command date I have input missed.

input: date + enter

[root /ctl]
$Fri Apr  9 11:49:48 CST 2021

command reset make terminal return normal.

The text was updated successfully, but these errors were encountered:

dshelley66 · 2021-04-12T20:06:13Z

I noticed the same thing - I think it is due to the pkg/term upgrade in v0.2.6 - downgrading to v0.2.5 seems to avoid this issue.

nodauf · 2021-04-15T18:25:45Z

for those you have the same issue. I did a workaround with the following code

func handleExit() {
	rawModeOff := exec.Command("/bin/stty", "-raw", "echo")
	rawModeOff.Stdin = os.Stdin
	_ = rawModeOff.Run()
	rawModeOff.Wait()
}

func main(){
	defer handleExit()
....
}

Neofish22 · 2021-05-26T17:53:18Z

Confirm @nodauf's solution works nicely. I believe stty sane is also a valid choice here.

This bug is introduced by 20e0658. Saving a *unix.Termios and then modifying it in SetRaw() makes the saved state useless. By restoring saveTermios type from *unix.Termios to unix.Termios, SetRaw() no longer influences the saved termios. This should fix c-bata#228 and c-bata#233 . Signed-off-by: Xiami <i@f2light.com>

hellojukay · 2022-01-26T07:50:40Z

reset command can restore the tty attribution

The patch adds a workaround for the bug "Terminal does not display command after go-prompt exit" (c-bata/go-prompt#228). Part of #15

The patch adds a workaround for the bug "Terminal does not display command after go-prompt exit" (c-bata/go-prompt#228).

elyscape · 2022-08-23T20:56:17Z

This happens because getOriginalTermios() returns a pointer to the original unix.Termios struct, and then SetRaw() modifies it. This can be fixed by changing getOriginalTermios() to copy saveTermios into a new struct and returning that:

func getOriginalTermios(fd int) (unix.Termios, error) {
	var err error
	saveTermiosOnce.Do(func() {
		saveTermiosFD = fd
		saveTermios, err = termios.Tcgetattr(uintptr(fd))
	})
	return *saveTermios, err
}

SetRaw() and Restore() would then need to be adjusted to pass a pointer to the variable they pass into termios.Tcsetattr().

Fixes: c-bata#228

elyscape · 2022-08-23T21:12:00Z

Incidentally, the reason this broke in v0.2.6 is that this was the version that changed getOriginalTermios() to return a pointer instead of a copied struct.

Fixes: c-bata#228

bluzarraga · 2022-09-13T16:15:04Z

@c-bata Is there any timeline for implementing this fix? I see there is a pr linked here and a similar one to address the same issue from June 2021 #239. I am also experiencing this issue consistently.

Fixed terminal brake after os.exit() in tt connect session. Have done it by adding workaround for the bug(c-bata/go-prompt#228) in case of executing os.exit(). Closes #425

The patch workaround issue [c-bata/go-prompt#228], make the terminal running ts-cli works correctly after quit, exit, ControlC or ControlD. Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>

mrpre added the bug label Apr 9, 2021

nodauf mentioned this issue Apr 15, 2021

Update module github.com/c-bata/go-prompt to v0.2.6 nodauf/Go-RouterSocks#3

Closed

1 task

Neofish22 mentioned this issue May 26, 2021

[Bug] After exiting the program, ctrl+c is invalid #233

Open

Xiami2012 linked a pull request Jun 17, 2021 that will close this issue

Fix wrong termios save code #239

Open

j0hax mentioned this issue Jul 7, 2021

Characters not echoing after after using autocomplete gennaro-tedesco/element#1

Closed

youkaicountry added a commit to koinos/koinos-cli that referenced this issue Jul 12, 2021

Roll back go-prompt version due to c-bata/go-prompt#228

8ec56f0

ishank011 mentioned this issue Sep 23, 2021

[docs-only] Generate cato docs and downgrade go-prompt to v0.2.5 cs3org/reva#2101

Merged

gregoo mentioned this issue Apr 18, 2022

Fix wrong termios save code gregoo/go-prompt#1

Merged

LeonidVas added a commit to tarantool/tt that referenced this issue Apr 18, 2022

connect: fix work with terminal

bcdac39

The patch adds a workaround for the bug "Terminal does not display command after go-prompt exit" (c-bata/go-prompt#228). Part of #15

LeonidVas added a commit to tarantool/tt that referenced this issue Apr 18, 2022

connect: fix work with terminal

c0377eb

The patch adds a workaround for the bug "Terminal does not display command after go-prompt exit" (c-bata/go-prompt#228). Part of #15

LeonidVas added a commit to tarantool/tt that referenced this issue Apr 19, 2022

connect: fix work with terminal

df7f722

The patch adds a workaround for the bug "Terminal does not display command after go-prompt exit" (c-bata/go-prompt#228). Part of #15

LeonidVas added a commit to tarantool/tt that referenced this issue Apr 20, 2022

connect: fix work with terminal

465dfde

The patch adds a workaround for the bug "Terminal does not display command after go-prompt exit" (c-bata/go-prompt#228). Part of #15

LeonidVas added a commit to tarantool/tt that referenced this issue Apr 20, 2022

connect: fix work with terminal

acec1f3

The patch adds a workaround for the bug "Terminal does not display command after go-prompt exit" (c-bata/go-prompt#228). Part of #15

LeonidVas added a commit to tarantool/tt that referenced this issue Apr 20, 2022

connect: fix work with terminal

f1111a9

The patch adds a workaround for the bug "Terminal does not display command after go-prompt exit" (c-bata/go-prompt#228). Part of #15

LeonidVas added a commit to tarantool/cartridge-cli that referenced this issue Apr 20, 2022

connect: fix work with terminal

ae60b65

The patch adds a workaround for the bug "Terminal does not display command after go-prompt exit" (c-bata/go-prompt#228).

LeonidVas mentioned this issue Apr 20, 2022

Fix work with terminal tarantool/cartridge-cli#699

Merged

LeonidVas added a commit to tarantool/cartridge-cli that referenced this issue Apr 20, 2022

connect: fix work with terminal

6eaba25

The patch adds a workaround for the bug "Terminal does not display command after go-prompt exit" (c-bata/go-prompt#228).

LeonidVas added a commit to tarantool/cartridge-cli that referenced this issue Apr 21, 2022

connect: fix work with terminal

a02420c

The patch adds a workaround for the bug "Terminal does not display command after go-prompt exit" (c-bata/go-prompt#228).

elyscape added a commit to elyscape/go-prompt that referenced this issue Aug 23, 2022

Avoid modifying saved terminal state

7fe657d

Fixes: c-bata#228

This was referenced Aug 23, 2022

Avoid modifying saved terminal state #263

Open

[v1 shell] Shell does not properly clean up the terminal influxdata/influx-cli#441

Closed

elyscape added a commit to elyscape/go-prompt that referenced this issue Sep 10, 2022

Avoid modifying saved terminal state

4758e87

Fixes: c-bata#228

elyscape mentioned this issue Sep 10, 2022

Avoid modifying saved terminal state influxdata/go-prompt#1

Merged

mattdesmarais mentioned this issue Oct 17, 2022

[Bug] Terminal Colors not reset after application exists #265

Open

congqixia mentioned this issue Dec 13, 2022

Fix go-prompt caused bash hijack milvus-io/birdwatcher#74

Merged

better0fdead mentioned this issue Apr 27, 2023

connect: fix terminal after executing os.exit() tarantool/tt#440

Merged

This was referenced Aug 11, 2023

Fix getOriginalTermios error not propagated when called multiple times elk-language/go-prompt#16

Merged

Fix #266 correctly restore terminal parameters elk-language/go-prompt#17

Merged

aandrew-me mentioned this issue Jan 14, 2024

Unable to use my terminal session after quitting the interactive mode since the last update. aandrew-me/tgpt#194

Closed

nanjj mentioned this issue Mar 8, 2024

Fixed terminal not restored after quit issue openGemini/openGemini#529

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Terminal does not display command after go-prompt exit #228

Terminal does not display command after go-prompt exit #228

mrpre commented Apr 9, 2021 •

edited

dshelley66 commented Apr 12, 2021

nodauf commented Apr 15, 2021

Neofish22 commented May 26, 2021

hellojukay commented Jan 26, 2022

elyscape commented Aug 23, 2022

elyscape commented Aug 23, 2022

bluzarraga commented Sep 13, 2022

Terminal does not display command after go-prompt exit #228

Terminal does not display command after go-prompt exit #228

Comments

mrpre commented Apr 9, 2021 • edited

Bug reports

dshelley66 commented Apr 12, 2021

nodauf commented Apr 15, 2021

Neofish22 commented May 26, 2021

hellojukay commented Jan 26, 2022

elyscape commented Aug 23, 2022

elyscape commented Aug 23, 2022

bluzarraga commented Sep 13, 2022

mrpre commented Apr 9, 2021 •

edited