Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can spawn inner instances for a large input collection #2890

Closed
saig0 opened this issue Jul 29, 2019 · 11 comments · Fixed by #12692
Closed

I can spawn inner instances for a large input collection #2890

saig0 opened this issue Jul 29, 2019 · 11 comments · Fixed by #12692
Assignees
Labels
area/performance Marks an issue as performance related component/engine kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/high Marks a bug as having a noticeable impact on the user with no known workaround support Marks an issue as related to a customer support request version:8.1.13 Marks an issue as being completely or in parts released in 8.1.13 version:8.2.5 Marks an issue as being completely or in parts released in 8.2.5 version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0

Comments

@saig0
Copy link
Member

saig0 commented Jul 29, 2019

Is your feature request related to a problem? Please describe.
At a multi-instance activity, I can define the input collection to iterate over. If the collection holds a large number of elements, the broker might fail to spawn the inner instances. Such a case can only be fixed, by manually decreasing the collection variable.

Describe the solution you'd like

  • I can spawn as many instances as defined by the input collection
  • instead of spawning the instances all at once on activating the body (current behavior), spawn the instances step-wise until all instances are created (e.g. spawn 10 instances and write a record to spawn the next 10)
  • the instance spawning can be interrupted by an event or a terminate command

Describe alternatives you've considered

Relates to
https://jira.camunda.com/browse/SUPPORT-16653
https://jira.camunda.com/browse/SUPPORT-16549

@saig0 saig0 added the kind/feature Categorizes an issue or PR as a feature, i.e. new behavior label Jul 29, 2019
@saig0 saig0 added Status: Planned scope/broker Marks an issue or PR to appear in the broker section of the changelog labels Jul 29, 2019
@saig0
Copy link
Member Author

saig0 commented Sep 27, 2019

Using Zeebe 0.21.0, we can execute a multi-instance activity with an input collection of ~ 5.000 elements (depending on the variables). By increasing the max message size, we could process even larger collections.

Since this is ok for now, we will postpone the issue.

@saig0 saig0 removed this from the Multi-Instance Activities milestone Sep 27, 2019
@npepinpe npepinpe added Status: Needs Priority area/performance Marks an issue as performance related kind/bug Categorizes an issue or PR as a bug and removed Status: Backlog kind/feature Categorizes an issue or PR as a feature, i.e. new behavior labels May 26, 2020
@npepinpe
Copy link
Member

npepinpe commented Dec 8, 2020

Just a side note, let's postpone at least until the new engine is done (i.e. at least Q2 2021). I can see us working on reducing the max message size next year, so we will need to implement this kind of "chunking" - obviously can't guarantee, but it sounds plausible to me.

@saig0
Copy link
Member Author

saig0 commented May 3, 2021

Update: I tested it again with version 1.0.0-alpha7. We can now iterate over an input collection with up to ~12.000 elements 🎉

@korthout
Copy link
Member

korthout commented Aug 30, 2022

Marking priority as later because 'multi-instance for large collections' is not the main concern for the process automation team right now. However, we should probably work on this when we work on

Note that the impact of this bug is reduced once we've resolved

Please comment if you think this should have a higher priority.

@epollum
Copy link

epollum commented Apr 6, 2023

Hello team, I want to mention that we have a customer who requires the ability to use large multi-instance activities. Please see https://jira.camunda.com/browse/SUPPORT-16499
And #11355

Thank you!

@saig0 saig0 added the support Marks an issue as related to a customer support request label Apr 11, 2023
@daniel-ewing
Copy link

Hi team, here is another one: https://jira.camunda.com/browse/SUPPORT-16653

@npepinpe
Copy link
Member

And another: https://jira.camunda.com/browse/SUPPORT-16549

@abbasadel
Copy link
Contributor

Team meeting: we changed the priority to "Upcoming" to pick this up when we have time

@abbasadel abbasadel added the severity/high Marks a bug as having a noticeable impact on the user with no known workaround label Apr 28, 2023
@remcowesterhoud remcowesterhoud self-assigned this May 2, 2023
zeebe-bors-camunda bot added a commit that referenced this issue May 11, 2023
12742: [Backport stable/8.1] Support large input collections for Multi-instance r=remcowesterhoud a=backport-action

# Description
Backport of #12692 to `stable/8.1`.

relates to #2890

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
zeebe-bors-camunda bot added a commit that referenced this issue May 11, 2023
12743: [Backport stable/8.2] Support large input collections for Multi-instance r=remcowesterhoud a=backport-action

# Description
Backport of #12692 to `stable/8.2`.

relates to #2890

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
@oleschoenburg oleschoenburg added the version:8.2.5 Marks an issue as being completely or in parts released in 8.2.5 label May 16, 2023
zeebe-bors-camunda bot added a commit that referenced this issue May 23, 2023
12742: [Backport stable/8.1] Support large input collections for Multi-instance r=remcowesterhoud a=backport-action

# Description
Backport of #12692 to `stable/8.1`.

relates to #2890

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
zeebe-bors-camunda bot added a commit that referenced this issue Jun 1, 2023
12742: [Backport stable/8.1] Support large input collections for Multi-instance r=remcowesterhoud a=backport-action

# Description
Backport of #12692 to `stable/8.1`.

relates to #2890

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
@oleschoenburg oleschoenburg added version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 version:8.1.13 Marks an issue as being completely or in parts released in 8.1.13 labels Jun 7, 2023
@felix-mueller
Copy link
Member

Hey @remcowesterhoud
I saw you worked on this item, there is one more item in the backlog: #8687

Could you perhaps elaborate if this is fixed now as well or is there a case which is not covered?
Could you perhaps explain which case is not covered for #8687?

Thanks
Felix

@remcowesterhoud
Copy link
Contributor

remcowesterhoud commented Aug 3, 2023

@felix-mueller from what I understand after reading #8687 it is a different issue. This one had to do with instance banning and the original author of the issue explicitly mentioned his instances weren't getting banned.

Whether this is fixed, I am not sure as I'm struggling to understand what is happening in the other issue 😅 @korthout do you have any ideas? It reads to me like it's more about job activation than multi-instance input collections.

If it's stale we can consider closing it and seeing if it ever occurs again.

@korthout
Copy link
Member

korthout commented Aug 4, 2023

@remcowesterhoud I've had a look. IMO, that issue is not specifically related to multi-instance, but rather to activating many jobs with large variables in the Go client.

I've provided my thoughts on that issue here

@megglos megglos added the version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0 label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Marks an issue as performance related component/engine kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/high Marks a bug as having a noticeable impact on the user with no known workaround support Marks an issue as related to a customer support request version:8.1.13 Marks an issue as being completely or in parts released in 8.1.13 version:8.2.5 Marks an issue as being completely or in parts released in 8.2.5 version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.