#853@minor: Fix method Range.cloneContents #854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #853
Seems the method initializes the initial subrange (the first element containing the start of the selection) incorrectly (Range.ts, line 282):
firstPartialContainedChild
.firstPartialContainedChild
.Seems that existing unit test did not catch this because selection does not start inside a sub element.
Minor additional fix: I removed the else-if branches in the
startOffset
andendOffset
getters. Code would only run into the else-if branch if theoffset
property is already 0 (otherwise the initial if-branch would trigger and reset theoffset
property to 0). Therefore the else-if branch does not have any effect.