Add additional helper method to init Google Client from specified file path #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krithika369
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
LGTM. Thanks for catching and fixing this, @deadlycoconuts !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This MR is a very similar follow-up to #78 and introduces another helper method to init the Google client (with both service and user accounts) from a specified file path.
In particular this is needed in XP's Treatment Service because we specify a precise filepath using a custom environment variable (something other than
GOOGLE_APPLICATION_CREDENTIALS) when initialising the Treatment Service as an experiment engine plugin in a Turing Router.