feat(linting): Improve sass linting using stylelint and a custom formatter #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniadeveloper
requested review from
blechner,
bryancboyd,
cgirani,
davidicus,
jessieyan,
JoelArmendariz,
leetosc,
scottdickerson,
sstone2423,
stuckless,
tay1orjones and
tomklapiscak
as code owners
sstone2423
previously requested changes
Jul 2, 2020
sass-msg-formatter.js
Outdated
| /* | ||
| * createCustomMessage: returns a custom message with a link to the carbon documentation depending on what the error is | ||
| */ | ||
| function createCustomMessage(text) { |
There was a problem hiding this comment.
could you add test coverage for this?
also could you add jsdocs for the param?
|
Deploy preview for carbon-addons-iot-react ready! Built with commit 82bfd2c https://deploy-preview-1359--carbon-addons-iot-react.netlify.app |
tay1orjones
reviewed
Jul 8, 2020
tay1orjones
reviewed
Jul 8, 2020
tay1orjones
requested changes
Jul 13, 2020
There was a problem hiding this comment.
It looks like there are two files here - sass-msg-formatter.js and sassMsgFormatter.js. Should there only be one? I don't see any usages of sass-msg-formatter.js
Instead of being at the root folder location, let's put these formatter config/js files in a new folder at ./config/stylelint
tay1orjones
reviewed
Jul 13, 2020
tay1orjones
reviewed
Jul 13, 2020
tay1orjones
reviewed
Jul 13, 2020
tay1orjones
reviewed
Jul 13, 2020
tay1orjones
reviewed
Jul 13, 2020
soniadeveloper
added
status: ready for review 👀
and removed
status: waiting for author's response 💬
labels
davidicus
reviewed
Jul 14, 2020
davidicus
approved these changes
Jul 14, 2020
davidicus
added
status: one more review 👀
and removed
status: ready for review 👀
labels
tay1orjones
requested changes
Jul 14, 2020
tay1orjones
approved these changes
Jul 14, 2020
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
tay1orjones
dismissed
sstone2423’s stale review
Feedback was implemented in a separate file
|
🎉 This PR is included in version 2.101.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #527
Summary
Change List (commits, features, bugs, etc)
Acceptance Test (how to verify the PR)
yarn lintin the main project folder