New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(port): Optimization tweaks #4634
Open
Kenan2000
wants to merge
11
commits into
main
Choose a base branch
from
optimizations_port_update1
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Zhilkin Serg <ZhilkinSerg@users.noreply.github.com> Co-Authored-By: Chaosvolt <chaosvolt@users.noreply.github.com>
Kenan2000
added
port request
Request to port functionality or content from DDA
src
PR changes related to source code.
tests
PR changes related to tests
labels
May 11, 2024
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
This was referenced May 11, 2024
Kenan2000
removed
the
port request
Request to port functionality or content from DDA
label
May 12, 2024
scarf005
changed the title
feat(port): Optimization tweaks
perf(port): Optimization tweaks
May 12, 2024
Co-Authored-By: Zhilkin Serg <ZhilkinSerg@users.noreply.github.com> Co-Authored-By: Chaosvolt <chaosvolt@users.noreply.github.com> Co-Authored-By: VissValdyr <167661460+VissValdyr@users.noreply.github.com> Co-Authored-By: Olanti <olanti-p@yandex.ru> Co-Authored-By: Coolthulhu <Coolthulhu@gmail.com>
…lysmbnteam/Cataclysm-BN into optimizations_port_update1
github-actions
bot
added
data
PRs related to datas. Won't crash game (probably)
mods
PR changes related to mods.
labels
May 15, 2024
github-actions
bot
removed
the
data
PRs related to datas. Won't crash game (probably)
label
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports this pull request
CleverRaven/Cataclysm-DDA#40961,
This also includes pull requests #4627, #4623 by @chaosvolt for easier mergeability
activity_handlers.cpp
file, line 1257 throws an error during compiling which, based on conversation with @Coolthulhu, will be fixed with help of Coolthulhu or other developers or bothCoauthors have been linked properly via GitHub Desktop built-in function to do this work hopefully