Avoid reserved identifiers in macros #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such identifiers are reserved by the C++ standard. Fixes part of catchorg#578.
2 tasks
Codecov Report
@@ Coverage Diff @@
## v2.x #2336 +/- ##
=======================================
Coverage 90.10% 90.10%
=======================================
Files 113 113
Lines 5038 5038
=======================================
Hits 4539 4539
Misses 499 499 |
|
Thanks. I would've used different names, but these are fine too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames all macros that are flagged by clang with
-Werror -Wreserved-identifier. Leading underscores are removed, multi-underscores inside macros reduced to one.With the proposed changes, Catch2 v2 can be used in a project which enables
-Werror -Wreserved-identifierwith clang-13 and above.GitHub Issues
Fixes part of #578.