Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "importlib_metadata remove deprecated entry point interfaces" #7833

Closed
wants to merge 1 commit into from

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Oct 19, 2022

Reverts #7785

@auvipy
Copy link
Member Author

auvipy commented Oct 19, 2022

@Nusnus even reverting this showing the doc build failure

@auvipy
Copy link
Member Author

auvipy commented Oct 19, 2022

@jaraco as you also reviewed the merged PR, can you please also check this why the doc build is throwing the error?

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 89.31% // Head: 89.32% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c8ea12d) compared to base (43924e3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7833   +/-   ##
=======================================
  Coverage   89.31%   89.32%           
=======================================
  Files         128      128           
  Lines       15926    15920    -6     
  Branches     2119     2118    -1     
=======================================
- Hits        14225    14221    -4     
+ Misses       1471     1469    -2     
  Partials      230      230           
Flag Coverage Δ
unittests 89.31% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/utils/imports.py 89.77% <0.00%> (+1.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Kludex Kludex mentioned this pull request Oct 19, 2022
@auvipy
Copy link
Member Author

auvipy commented Oct 19, 2022

@Kludex what about trying lower sphinx version?

@woutdenolf
Copy link
Contributor

woutdenolf commented Oct 19, 2022

This can be closed. The error comes from kombu (fixed in celery/kombu#1601). It has nothing to do with #7785.

@auvipy
Copy link
Member Author

auvipy commented Oct 19, 2022

yes you are right, keeping this open until kombu5.3.0b2 is released and tested

@auvipy auvipy closed this Oct 20, 2022
@auvipy auvipy deleted the revert-7785-fix_issue_7783 branch October 20, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants