Handle empty ceph_version in ceph_mon_metadata to avoid raising misleading alert #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
Instead of using 'absent' query, we are trying to use 'up' which should provide us with the needed 'namespace' field in the resultant metrics Signed-off-by: aruniiird <amohan@redhat.com>
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
The following alerts, CephMonHighNumberOfLeaderChanges CephOSDDiskNotResponding CephClusterWarningState , which are resolved automatically, in most cases, are causing unnecessary admin events. So we are increasing the alert delay time to '15m'. Signed-off-by: aruniiird <amohan@redhat.com>
Reverting the time delay of 'CephMonHighNumberOfLeaderChanges' back to 5m Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
…raising misleading alert Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
GowthamShanmugam
force-pushed
the
1970354
branch
from
eb03340
to
a5fa42d
Compare
Merged
10 tasks
This was referenced Oct 14, 2021
|
@umangachapagain Please review |
umangachapagain
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the ceph version, we can't clearly report that the version is different, or that the version is the same.
QE already raised a BZ at the ceph side to fix this. We are adding this not empty check to avoid misreport from other cases also.
Please review commit: a5fa42d