-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.14] BUGFIX: cainjector leaderelection defaults are missing #6819
Merged
jetstack-bot
merged 2 commits into
cert-manager:release-1.14
from
jetstack-bot:cherry-pick-6816-to-release-1.14
Mar 6, 2024
Merged
[release-1.14] BUGFIX: cainjector leaderelection defaults are missing #6819
jetstack-bot
merged 2 commits into
cert-manager:release-1.14
from
jetstack-bot:cherry-pick-6816-to-release-1.14
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
jetstack-bot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
dco-signoff: yes
Indicates that all commits in the pull request have the valid DCO sign-off message.
needs-kind
Indicates a PR lacks a `kind/foo` label and requires one.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Mar 6, 2024
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Mar 6, 2024
/kind bug |
jetstack-bot
added
kind/bug
Categorizes issue or PR as related to a bug.
and removed
needs-kind
Indicates a PR lacks a `kind/foo` label and requires one.
labels
Mar 8, 2024
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Mar 9, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cert-manager](https://github.com/cert-manager/cert-manager) | patch | `v1.14.3` -> `v1.14.4` | --- ### Release Notes <details> <summary>cert-manager/cert-manager (cert-manager)</summary> ### [`v1.14.4`](https://github.com/cert-manager/cert-manager/releases/tag/v1.14.4) [Compare Source](cert-manager/cert-manager@v1.14.3...v1.14.4) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. cert-manager 1.14 brings a variety of features, security improvements and bug fixes, including: support for creating X.509 certificates with "Other Name" fields, and support for creating CA certificates with "Name Constraints" and "Authority Information Accessors" extensions. #####⚠️ Known Issues - ACME Issuer (Let's Encrypt): wrong certificate chain may be used if preferredChain is configured: see [release docs](https://cert-manager.io/docs/releases/release-notes/release-notes-1.14/#acme-issuer-lets-encrypt-wrong-certificate-chain-may-be-used-if-preferredchain-is-configured---6755-6757) for more info and mitigations ##### ℹ️ Documentation [Release notes](https://cert-manager.io/docs/releases/release-notes/release-notes-1.14) [Upgrade notes](https://cert-manager.io/docs/releases/upgrading/upgrading-1.13-1.14) [Installation instructions](https://cert-manager.io/docs/installation/) ##### 🔧 Breaking changes See Breaking changes in [v1.14.0 release notes](https://github.com/cert-manager/cert-manager/releases/tag/v1.14.0) ##### 📜 Changes since v1.14.3 ##### Bug or Regression - Allow `cert-manager.io/allow-direct-injection` in annotations ([#​6809](cert-manager/cert-manager#6809), [@​jetstack-bot](https://github.com/jetstack-bot)) - BUGFIX: JKS and PKCS12 stores now contain the full set of CAs specified by an issuer ([#​6812](cert-manager/cert-manager#6812), [@​jetstack-bot](https://github.com/jetstack-bot)) - BUGFIX: cainjector leaderelection flag/ config option defaults are missing ([#​6819](cert-manager/cert-manager#6819), [@​jetstack-bot](https://github.com/jetstack-bot)) ##### Other (Cleanup or Flake) - Bump base images. ([#​6842](cert-manager/cert-manager#6842), [@​inteon](https://github.com/inteon)) - Upgrade Helm: fix CVE-2024-26147 alert ([#​6834](cert-manager/cert-manager#6834), [@​inteon](https://github.com/inteon)) - Upgrade go to 1.21.8: fixes CVE-2024-24783 ([#​6825](cert-manager/cert-manager#6825), [@​jetstack-bot](https://github.com/jetstack-bot)) - Upgrade google.golang.org/protobuf: fixing GO-2024-2611 ([#​6829](cert-manager/cert-manager#6829), [@​inteon](https://github.com/inteon)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/425 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
lambchop4prez
added a commit
to lambchop4prez/network
that referenced
this pull request
Apr 7, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cert-manager](https://cert-manager.io) ([source](https://togithub.com/cert-manager/cert-manager)) | minor | `v1.13.0` -> `v1.14.4` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>cert-manager/cert-manager (cert-manager)</summary> ### [`v1.14.4`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.14.4) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.14.3...v1.14.4) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. cert-manager 1.14 brings a variety of features, security improvements and bug fixes, including: support for creating X.509 certificates with "Other Name" fields, and support for creating CA certificates with "Name Constraints" and "Authority Information Accessors" extensions. #####⚠️ Known Issues - ACME Issuer (Let's Encrypt): wrong certificate chain may be used if preferredChain is configured: see [release docs](https://cert-manager.io/docs/releases/release-notes/release-notes-1.14/#acme-issuer-lets-encrypt-wrong-certificate-chain-may-be-used-if-preferredchain-is-configured---6755-6757) for more info and mitigations ##### ℹ️ Documentation [Release notes](https://cert-manager.io/docs/releases/release-notes/release-notes-1.14) [Upgrade notes](https://cert-manager.io/docs/releases/upgrading/upgrading-1.13-1.14) [Installation instructions](https://cert-manager.io/docs/installation/) ##### 🔧 Breaking changes See Breaking changes in [v1.14.0 release notes](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.14.0) ##### 📜 Changes since v1.14.3 ##### Bug or Regression - Allow `cert-manager.io/allow-direct-injection` in annotations ([#​6809](https://togithub.com/cert-manager/cert-manager/issues/6809), [@​jetstack-bot](https://togithub.com/jetstack-bot)) - BUGFIX: JKS and PKCS12 stores now contain the full set of CAs specified by an issuer ([#​6812](https://togithub.com/cert-manager/cert-manager/issues/6812), [@​jetstack-bot](https://togithub.com/jetstack-bot)) - BUGFIX: cainjector leaderelection flag/ config option defaults are missing ([#​6819](https://togithub.com/cert-manager/cert-manager/issues/6819), [@​jetstack-bot](https://togithub.com/jetstack-bot)) ##### Other (Cleanup or Flake) - Bump base images. ([#​6842](https://togithub.com/cert-manager/cert-manager/issues/6842), [@​inteon](https://togithub.com/inteon)) - Upgrade Helm: fix CVE-2024-26147 alert ([#​6834](https://togithub.com/cert-manager/cert-manager/issues/6834), [@​inteon](https://togithub.com/inteon)) - Upgrade go to 1.21.8: fixes CVE-2024-24783 ([#​6825](https://togithub.com/cert-manager/cert-manager/issues/6825), [@​jetstack-bot](https://togithub.com/jetstack-bot)) - Upgrade google.golang.org/protobuf: fixing GO-2024-2611 ([#​6829](https://togithub.com/cert-manager/cert-manager/issues/6829), [@​inteon](https://togithub.com/inteon)) ### [`v1.14.3`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.14.3) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.14.2...v1.14.3) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. cert-manager 1.14 brings a variety of features, security improvements and bug fixes, including: support for creating X.509 certificates with "Other Name" fields, and support for creating CA certificates with "Name Constraints" and "Authority Information Accessors" extensions. #####⚠️ Known Issues - ACME Issuer (Let's Encrypt): wrong certificate chain may be used if preferredChain is configured: see [release docs](https://cert-manager.io/docs/releases/release-notes/release-notes-1.14/#acme-issuer-lets-encrypt-wrong-certificate-chain-may-be-used-if-preferredchain-is-configured---6755-6757) for more info and mitigations - cainjector leaderelection is incorrectly disabled by default because the flag/ config option defaults are missing ([cert-manager/cert-manager#6819) ##### ℹ️ Documentation [Release notes](https://cert-manager.io/docs/releases/release-notes/release-notes-1.14) [Upgrade notes](https://cert-manager.io/docs/releases/upgrading/upgrading-1.13-1.14) [Installation instructions](https://cert-manager.io/docs/installation/) ##### 🔧 Breaking changes See Breaking changes in [v1.14.0 release notes](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.14.0) ##### 📜 Changes since v1.14.2 ##### Bug or Regression - BUGFIX: Fixes issue with JSON-logging, where only a subset of the log messages were output as JSON. ([#​6781](https://togithub.com/cert-manager/cert-manager/issues/6781), [@​jetstack-bot](https://togithub.com/jetstack-bot)) - BUGFIX: LiteralSubjects with a #= value can result in memory issues due to faulty BER parser (github.com/go-asn1-ber/asn1-ber). ([#​6774](https://togithub.com/cert-manager/cert-manager/issues/6774), [@​jetstack-bot](https://togithub.com/jetstack-bot)) ### [`v1.14.2`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.14.2) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.14.1...v1.14.2) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. cert-manager 1.14 brings a variety of features, security improvements and bug fixes, including: support for creating X.509 certificates with "Other Name" fields, and support for creating CA certificates with "Name Constraints" and "Authority Information Accessors" extensions. ##### ℹ️ Documentation [Release notes](https://cert-manager.io/docs/releases/release-notes/release-notes-1.14) [Upgrade notes](https://cert-manager.io/docs/releases/upgrading/upgrading-1.13-1.14) [Installation instructions](https://cert-manager.io/docs/installation/) ##### 🔧 Breaking changes See `Breaking changes` in [v1.14.0 release notes](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.14.0) ##### 📜 Changes since `v1.14.1` ##### Bug or Regression - BUGFIX: cert-manager CA and SelfSigned issuers incorrectly copied the critical flag from the CSR instead of re-calculating that field themselves. ([#​6727](https://togithub.com/cert-manager/cert-manager/issues/6727), [@​jetstack-bot](https://togithub.com/jetstack-bot)) - Helm: Fix a bug in the logic that differentiates between 0 and an empty value. ([#​6729](https://togithub.com/cert-manager/cert-manager/issues/6729), [@​jetstack-bot](https://togithub.com/jetstack-bot)) ##### Other (Cleanup or Flake) - Bump golang to 1.21.7 ([#​6735](https://togithub.com/cert-manager/cert-manager/issues/6735), [@​jetstack-bot](https://togithub.com/jetstack-bot)) ### [`v1.14.1`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.14.1) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.14.0...v1.14.1) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. cert-manager 1.14 brings a variety of features, security improvements and bug fixes, including: support for creating X.509 certificates with "Other Name" fields, and support for creating CA certificates with "Name Constraints" and "Authority Information Accessors" extensions. >⚠️ This version has known issues. Please install `v1.14.2` instead. #####⚠️ Known Issues (fixed in `v1.14.2`) - In cert-manager v1.14.0 and v1.14.1, the `CA` and `SelfSigned` issuers issue certificates with SANs set to non-critical even when the subject is empty. It incorrectly copies the critical field from the CSR. ##### 🔧 Breaking changes See `Breaking changes` in [v1.14.0 release notes](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.14.0) ##### ℹ️ Documentation - [Release notes](https://cert-manager.io/docs/releases/release-notes/release-notes-1.14) - [Upgrade notes](https://cert-manager.io/docs/releases/upgrading/upgrading-1.13-1.14) - [Installation instructions](https://cert-manager.io/docs/installation/) ##### 📜 Changes since `v1.14.0` ##### Bug or Regression - Fix broken cainjector image value in Helm chart ([#​6693](https://togithub.com/cert-manager/cert-manager/pull/6693), [@​SgtCoDFish](https://togithub.com/SgtCoDFish)) - Fix bug in cmctl namespace detection which prevented it being used as a startupapicheck image in namespaces other than cert-manager. ([#​6706](https://togithub.com/cert-manager/cert-manager/pull/6706), [@​inteon](https://togithub.com/inteon)) - Fix bug in cmctl which caused `cmctl experimental install` to panic. ([#​6706](https://togithub.com/cert-manager/cert-manager/pull/6706), [@​inteon](https://togithub.com/inteon)) ### [`v1.14.0`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.14.0) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.13.5...v1.14.0) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. cert-manager 1.14 brings a variety of features, security improvements and bug fixes, including: support for creating X.509 certificates with "Other Name" fields, and support for creating CA certificates with "Name Constraints" and "Authority Information Accessors" extensions. >⚠️ This version has known issues. Please install `v1.14.2` instead. #####⚠️ Known Issues (fixed in `v1.14.1+`) - During the release of `v1.14.0`, the Helm chart for this version was found to use the wrong OCI image for the `cainjector` Deployment, which caused the Helm installation to fail. In order to complete the release, the cert-manager team have manually updated the Helm chart for this version, which contains all the Helm chart fixes which are in `v1.14.1`. - A bug in cmctl namespace detection prevents it being used as a `startupapicheck` image in namespaces other than cert-manager. - A bug in cmctl causes `cmctl experimental install` to panic. ##### 🔧 Breaking Changes The startupapicheck job uses a new OCI image called "startupapicheck", instead of the ctl image. If you run in an environment in which images cannot be pulled, be sure to include the new image. The KeyUsage and BasicConstraints extensions will now be encoded as critical in the CertificateRequest's CSR blob. ##### 🗺️ Major Themes ##### New X.509 Features The cert-manager Certificate resource now allows you to configure a subset of "Other Name" SANs, which are described in the [Subject Alternative Name section of RFC 5280](https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.1.6) (on page 37). We specifically support any `otherName` type with a `UTF-8` value, such as the [User Principal Name](https://docs.venafi.com/Docs/current/TopNav/Content/Certificates/r-UEP-support-SANs.php) or [`sAMAccountName`](https://learn.microsoft.com/en-us/windows/win32/ad/naming-properties). These are useful when issuing unique certificates for authenticating with LDAP systems such as Microsoft Active Directory. For example you can create certificates with this block in the spec: otherNames: - oid: 1.3.6.1.4.1.311.20.2.3 # UPN OID utf8Value: upn@domain.local The feature is still in alpha stage and requires you to [enable the `OtherName` feature flag in the controller and webhook components](../../installation/configuring-components.md#feature-gates). ##### New CA certificate Features You can now specify the X.509 v3 Authority Information Accessors extension, with URLs for certificates issued by the CA issuer. Users can now use name constraints in CA certificates. To know more details on name constraints check out RFC section https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.1.10 ##### Security An ongoing security audit of the cert-manager code revealed some weaknesses which we have addressed in this release, such as using more secure default settings in the HTTP servers that serve metrics, healthz and pprof endpoints. This will help mitigate denial-of-service attacks against those important services. All the cert-manager containers are now configured with read only root file system by default, to prevent unexpected changes to the file system of the OCI image. And it is now possible to configure the metrics server to use HTTPS rather than HTTP, so that clients can verify the identity of the metrics server. ##### Other The liveness probe of the cert-manager controller Pod is now enabled by default. There is a new option `.spec.keystores.pkcs12.algorithms` to specify encryption and MAC algorithms for PKCS. ##### 🤝 Community Thanks again to all open-source contributors with commits in this release, including: - [@​ABWassim](https://togithub.com/ABWassim) - [@​JoeNorth](https://togithub.com/JoeNorth) - [@​allenmunC1](https://togithub.com/allenmunC1) - [@​asapekia](https://togithub.com/asapekia) - [@​jeremycampbell](https://togithub.com/jeremycampbell) - [@​jkroepke](https://togithub.com/jkroepke) - [@​jsoref](https://togithub.com/jsoref) - [@​lauraseidler](https://togithub.com/lauraseidler) - [@​pevidex](https://togithub.com/pevidex) - [@​phillebaba](https://togithub.com/phillebaba) - [@​snorwin](https://togithub.com/snorwin) - [@​tanujd11](https://togithub.com/tanujd11) - [@​tberreis](https://togithub.com/tberreis) - [@​vinny](https://togithub.com/vinny) Thanks also to the following cert-manager maintainers for their contributions during this release: - [@​SgtCoDFish](https://togithub.com/SgtCoDFish) - [@​SpectralHiss](https://togithub.com/SpectralHiss) - [@​ThatsMrTalbot](https://togithub.com/ThatsMrTalbot) - [@​hawksight](https://togithub.com/hawksight) - [@​inteon](https://togithub.com/inteon) - [@​maelvls](https://togithub.com/maelvls) - [@​wallrj](https://togithub.com/wallrj) Equally thanks to everyone who provided feedback, helped users and raised issues on GitHub and Slack and joined our meetings! Thanks also to the [CNCF](https://www.cncf.io/), which provides resources and support, and to the AWS open source team for being good community members and for their maintenance of the [PrivateCA Issuer](https://togithub.com/cert-manager/aws-privateca-issuer). In addition, massive thanks to [Venafi](https://www.venafi.com/) for contributing developer time and resources towards the continued maintenance of cert-manager projects. ##### 📜 Changes ##### Feature - ACME challenge solver Pod for HTTP01 will get a default annotation of `"cluster-autoscaler.kubernetes.io/safe-to-evict": "true"`. You can provide an annotation of `"cluster-autoscaler.kubernetes.io/safe-to-evict": "false"` in your `podTemplate` if you don't like this. ([#​6349](https://togithub.com/cert-manager/cert-manager/pull/6349), [@​jsoref](https://togithub.com/jsoref)) - Added a clock skew detector liveness probe that will force a restart in case we detect a skew between the internal monotonic clock and the system clock of more than 5 minutes. Also, the controller's liveness probe is now enabled by default. ([#​6328](https://togithub.com/cert-manager/cert-manager/pull/6328), [@​inteon](https://togithub.com/inteon)) - Added a new flag (--dynamic-serving-leaf-duration) that can adjust the lifetime of the dynamic leaf certificates ([#​6552](https://togithub.com/cert-manager/cert-manager/pull/6552), [@​allenmunC1](https://togithub.com/allenmunC1)) - Added support for `otherName` SANS in Certificates ([#​6404](https://togithub.com/cert-manager/cert-manager/pull/6404), [@​SpectralHiss](https://togithub.com/SpectralHiss)) - Added the option to specify the X.509 v3 Authority Information Accessors extension CA Issuers URLs for certificates issued by the CA issuer. ([#​6486](https://togithub.com/cert-manager/cert-manager/pull/6486), [@​jeremycampbell](https://togithub.com/jeremycampbell-okta)) - Adds cert-manager's new core infrastructure initiative badge! See more details on https://www.bestpractices.dev/projects/8079 ([#​6497](https://togithub.com/cert-manager/cert-manager/pull/6497), [@​SgtCoDFish](https://togithub.com/SgtCoDFish)) - All Pods are now configured with `readOnlyRootFilesystem` by default. ([#​6453](https://togithub.com/cert-manager/cert-manager/pull/6453), [@​wallrj](https://togithub.com/wallrj)) - MAYBE BREAKING: The startupapicheck job is now handled by an entirely new container called "startupapicheck". This replaces the previous ctl container. If you run in an environment in which images cannot be pulled, be sure to include the new container. ([#​6549](https://togithub.com/cert-manager/cert-manager/pull/6549), [@​SgtCoDFish](https://togithub.com/SgtCoDFish)) - New option `.spec.keystores.pkcs12.algorithms` to specify encryption and MAC algorithms for PKCS[#​12](https://togithub.com/cert-manager/cert-manager/pull/12) keystores. Fixes issues [#​5957](https://togithub.com/cert-manager/cert-manager/pull/5957) and [#​6523](https://togithub.com/cert-manager/cert-manager/pull/6523). ([#​6548](https://togithub.com/cert-manager/cert-manager/pull/6548), [@​snorwin](https://togithub.com/snorwin)) - The ACME HTTP01 solver Pod is now configured with `readOnlyRootFilesystem: true` ([#​6462](https://togithub.com/cert-manager/cert-manager/pull/6462), [@​wallrj](https://togithub.com/wallrj)) - Updates the AWS SDK for Go to 1.48.7 to support Amazon EKS Pod Identity ([#​6519](https://togithub.com/cert-manager/cert-manager/pull/6519), [@​JoeNorth](https://togithub.com/JoeNorth)) - Users can now use name constraints in CA certificates. To know more details on name constraints check out RFC section https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.1.10 ([#​6500](https://togithub.com/cert-manager/cert-manager/pull/6500), [@​tanujd11](https://togithub.com/tanujd11)) -⚠️ potentially breaking⚠️ : The KeyUsage and BasicConstraints extensions will now be encoded as critical in the CertificateRequest's CSR blob. ([#​6053](https://togithub.com/cert-manager/cert-manager/pull/6053), [@​inteon](https://togithub.com/inteon)) - Add TLS support to the metrics endpoint through either a certificate file or through dynamically issued certificates ([#​6574](https://togithub.com/cert-manager/cert-manager/pull/6574), [@​ThatsMrTalbot](https://togithub.com/ThatsMrTalbot)) - Helm Chart: allow changing the default Deployment `revisionHistoryLimit` ([#​6248](https://togithub.com/cert-manager/cert-manager/pull/6248), [@​tberreis](https://togithub.com/tberreis)) - Security: Limit the size of the response body read from HTTP requests by cert-manager. ([#​6619](https://togithub.com/cert-manager/cert-manager/pull/6619), [@​ThatsMrTalbot](https://togithub.com/ThatsMrTalbot)) - Support custom `spec.namespaceSelector` for webhooks ([#​6638](https://togithub.com/cert-manager/cert-manager/pull/6638), [@​jkroepke](https://togithub.com/jkroepke)) ##### Bug or Regression - BUGFIX\[helm]: Fix issue where webhook feature gates were only set if controller feature gates are set. ([#​6380](https://togithub.com/cert-manager/cert-manager/pull/6380), [@​asapekia](https://togithub.com/asapekia)) - Controller ConfigMap is now created only if `.Values.config` is set. ([#​6357](https://togithub.com/cert-manager/cert-manager/pull/6357), [@​ABWassim](https://togithub.com/ABWassim)) - Fix runaway bug caused by multiple Certificate resources that point to the same Secret resource. ([#​6406](https://togithub.com/cert-manager/cert-manager/pull/6406), [@​inteon](https://togithub.com/inteon)) - Fix(helm): templating of required value in controller and webhook ConfigMap resources ([#​6435](https://togithub.com/cert-manager/cert-manager/pull/6435), [@​ABWassim](https://togithub.com/ABWassim)) - Fixed a webhook validation error message when the key algorithm was invalid. ([#​6571](https://togithub.com/cert-manager/cert-manager/pull/6571), [@​pevidex](https://togithub.com/pevidex)) - Fixed error messaging when setting up vault issuer ([#​6433](https://togithub.com/cert-manager/cert-manager/pull/6433), [@​vinny](https://togithub.com/vinny-sabatini)) - `GHSA-vgf6-pvf4-34rq`: The webhook server now returns HTTP error 413 (Content Too Large) for requests with body size `>= 3MiB`. This is to mitigate DoS attacks that attempt to crash the webhook process by sending large requests that exceed the available memory. The webhook server now returns HTTP error 400 (Bad Request) if the request contains an empty body. The webhook server now returns HTTP error 500 (Internal Server Error) rather than crashing, if the code panics while handling a request. ([#​6498](https://togithub.com/cert-manager/cert-manager/pull/6498), [@​inteon](https://togithub.com/inteon)) - Increase the default webhook timeout to its maximum value of 30 seconds, so that the underlying timeout error message has more chance of being returned to the end user. ([#​6488](https://togithub.com/cert-manager/cert-manager/pull/6488), [@​wallrj](https://togithub.com/wallrj)) - Listeners that do not support TLS on Gateway resources will now not raise `BadConfig` warnings anymore ([#​6347](https://togithub.com/cert-manager/cert-manager/pull/6347), [@​lauraseidler](https://togithub.com/lauraseidler)) - Mitigate potential Slowloris attacks by setting `ReadHeaderTimeout` in all `http.Server` instances ([#​6534](https://togithub.com/cert-manager/cert-manager/pull/6534), [@​wallrj](https://togithub.com/wallrj)) - The Venafi issuer now properly resets the certificate and should no longer get stuck with `WebSDK CertRequest Module Requested Certificate` or `This certificate cannot be processed while it is in an error state. Fix any errors, and then click Retry.`. ([#​6398](https://togithub.com/cert-manager/cert-manager/pull/6398), [@​maelvls](https://togithub.com/maelvls)) - Update experimental install and uninstall commands to have flag parity with the rest of the CLI ([#​6562](https://togithub.com/cert-manager/cert-manager/pull/6562), [@​ThatsMrTalbot](https://togithub.com/ThatsMrTalbot)) - Webhook ConfigMap if now created only if `.Values.webhook.config` is set. ([#​6360](https://togithub.com/cert-manager/cert-manager/pull/6360), [@​ABWassim](https://togithub.com/ABWassim)) - BUGFIX: Ensure `otherName` SAN changes in Certificate resources trigger re-issuance. ([#​6620](https://togithub.com/cert-manager/cert-manager/pull/6620), [@​SpectralHiss](https://togithub.com/SpectralHiss)) - Bugfix: Publish the `startupapicheck` image to `quay.io` ([#​6609](https://togithub.com/cert-manager/cert-manager/pull/6609), [@​wallrj](https://togithub.com/wallrj)) ##### Other (Cleanup or Flake) - Cert-manager is now built with Go 1.21.5 ([#​6545](https://togithub.com/cert-manager/cert-manager/pull/6545), [@​wallrj](https://togithub.com/wallrj)) - Bump Go to `1.21.3` to address `CVE-2023-39325`. Also bumps base images. ([#​6410](https://togithub.com/cert-manager/cert-manager/pull/6410), [@​SgtCoDFish](https://togithub.com/SgtCoDFish)) - Bump `golang.org/x/net v0.15.0 => v0.17.0` as part of addressing `CVE-2023-44487` / `CVE-2023-39325` ([#​6427](https://togithub.com/cert-manager/cert-manager/pull/6427), [@​SgtCoDFish](https://togithub.com/SgtCoDFish)) - Check code for unintended use of `crypto/md5`, a weak cryptographic primitive; using `golangci-lint` / `gosec` (G501). ([#​6581](https://togithub.com/cert-manager/cert-manager/pull/6581), [@​wallrj](https://togithub.com/wallrj)) - Check code for unintended use of `crypto/sha1`, a weak cryptographic primitive; using `golangci-lint` / `gosec` (G505). ([#​6579](https://togithub.com/cert-manager/cert-manager/pull/6579), [@​wallrj](https://togithub.com/wallrj)) - Check code for unintended use of weak random number generator (`math/rand` instead of `crypto/rand`); using `golangci-lint` / `gosec` (G404). ([#​6582](https://togithub.com/cert-manager/cert-manager/pull/6582), [@​wallrj](https://togithub.com/wallrj)) - Cleanup: Restrict MutatingWebhookConfiguration to only CertificateRequest resources ([#​6311](https://togithub.com/cert-manager/cert-manager/pull/6311), [@​hawksight](https://togithub.com/hawksight)) - Deprecated `pkg/util.RandStringRunes` and `pkg/controller/test.RandStringBytes`. Use `k8s.io/apimachinery/pkg/util/rand.String` instead. ([#​6585](https://togithub.com/cert-manager/cert-manager/pull/6585), [@​wallrj](https://togithub.com/wallrj)) - Enabled verbose logging in startupapicheck by default, so that if it fails, users can know exactly what caused the failure. ([#​6495](https://togithub.com/cert-manager/cert-manager/pull/6495), [@​wallrj](https://togithub.com/wallrj)) - Fix gosec G601: Implicit memory aliasing of items from a range statement ([#​6551](https://togithub.com/cert-manager/cert-manager/pull/6551), [@​wallrj](https://togithub.com/wallrj)) - Fix handling of serial numbers in literal certificate subjects. Previously a serial number could be specified in `subject.serialNumber` while using a literal certificate subject. This was a mistake and has been fixed. ([#​6533](https://togithub.com/cert-manager/cert-manager/pull/6533), [@​inteon](https://togithub.com/inteon)) - The end-to-end tests can now test the cert-manager Vault Issuer on an OpenShift cluster. ([#​6391](https://togithub.com/cert-manager/cert-manager/pull/6391), [@​wallrj](https://togithub.com/wallrj)) - Update cert-manager's distroless base images from Debian 11 to Debian 12. This should have no practical effects on users. ([#​6583](https://togithub.com/cert-manager/cert-manager/pull/6583), [@​inteon](https://togithub.com/inteon)) - Updated all code using GatewayAPI to use the now GA v1 APIs ([#​6559](https://togithub.com/cert-manager/cert-manager/pull/6559), [@​ThatsMrTalbot](https://togithub.com/ThatsMrTalbot)) - Upgrade Go from 1.20.7 to 1.20.8. ([#​6369](https://togithub.com/cert-manager/cert-manager/pull/6369), [@​inteon](https://togithub.com/inteon)) - Upgrade `github.com/emicklei/go-restful/v3` to `v3.11.0` because `v3.10.2` is labeled as "DO NOT USE". ([#​6366](https://togithub.com/cert-manager/cert-manager/pull/6366), [@​inteon](https://togithub.com/inteon)) - Use the new generic `sets.Set` type in place of the deprecated `sets.String`. ([#​6586](https://togithub.com/cert-manager/cert-manager/pull/6586), [@​wallrj](https://togithub.com/wallrj)) - cert-manager is now built with Go `v1.21.6` ([#​6628](https://togithub.com/cert-manager/cert-manager/pull/6628), [@​SgtCoDFish](https://togithub.com/SgtCoDFish)) - Update the Azure SDK and remove deprecated `autorest` dependency ([#​5452](https://togithub.com/cert-manager/cert-manager/pull/5452), [@​phillebaba](https://togithub.com/phillebaba)) - The cert-manager E2E tests can now be run on Kubernetes 1.29 ([#​6641](https://togithub.com/cert-manager/cert-manager/pull/6641), [@​wallrj](https://togithub.com/wallrj)) ### [`v1.13.5`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.5) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.13.4...v1.13.5) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. #####⚠️ Known Issues - ACME Issuer (Let's Encrypt): wrong certificate chain may be used if preferredChain is configured: see [release docs](https://cert-manager.io/docs/releases/release-notes/release-notes-1.14/#acme-issuer-lets-encrypt-wrong-certificate-chain-may-be-used-if-preferredchain-is-configured---6755-6757) for more info and mitigations ##### ℹ️ Documentation [Release notes](https://cert-manager.io/docs/releases/release-notes/release-notes-1.13) [Upgrade notes](https://cert-manager.io/docs/releases/upgrading/upgrading-1.12-1.13) [Installation instructions](https://cert-manager.io/docs/installation/) ##### 🔧 Breaking changes See Breaking changes in [v1.13.0 release notes](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.0) ##### 📜 Changes since v1.13.4 ##### Bug or Regression - Allow `cert-manager.io/allow-direct-injection` in annotations ([#​6810](https://togithub.com/cert-manager/cert-manager/issues/6810), [@​jetstack-bot](https://togithub.com/jetstack-bot)) - BUGFIX: JKS and PKCS12 stores now contain the full set of CAs specified by an issuer ([#​6814](https://togithub.com/cert-manager/cert-manager/issues/6814), [@​inteon](https://togithub.com/inteon)) - BUGFIX: fix race condition due to registering and using global runtime.Scheme variables ([#​6832](https://togithub.com/cert-manager/cert-manager/issues/6832), [@​inteon](https://togithub.com/inteon)) ##### Other (Cleanup or Flake) - Bump base images to the latest version. ([#​6841](https://togithub.com/cert-manager/cert-manager/issues/6841), [@​inteon](https://togithub.com/inteon)) - Upgrade go to 1.21.8: fixes CVE-2024-24783 ([#​6824](https://togithub.com/cert-manager/cert-manager/issues/6824), [@​inteon](https://togithub.com/inteon)) - Upgrade google.golang.org/protobuf: fixing GO-2024-2611 ([#​6828](https://togithub.com/cert-manager/cert-manager/issues/6828), [@​inteon](https://togithub.com/inteon)) ### [`v1.13.4`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.4) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.13.3...v1.13.4) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. #####⚠️ Known Issues - ACME Issuer (Let's Encrypt): wrong certificate chain may be used if preferredChain is configured: see [release docs](https://cert-manager.io/docs/releases/release-notes/release-notes-1.14/#acme-issuer-lets-encrypt-wrong-certificate-chain-may-be-used-if-preferredchain-is-configured---6755-6757) for more info and mitigations ##### ℹ️ Documentation [Release notes](https://cert-manager.io/docs/releases/release-notes/release-notes-1.13) [Upgrade notes](https://cert-manager.io/docs/releases/upgrading/upgrading-1.12-1.13) [Installation instructions](https://cert-manager.io/docs/installation/) ##### 🔧 Breaking changes See Breaking changes in [v1.13.0 release notes](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.0) ##### 📜 Changes since v1.13.3 ##### Bug or Regression - BUGFIX: LiteralSubjects with a #= value can result in memory issues due to faulty BER parser (github.com/go-asn1-ber/asn1-ber). ([#​6772](https://togithub.com/cert-manager/cert-manager/issues/6772), [@​jetstack-bot](https://togithub.com/jetstack-bot)) ##### Other (Cleanup or Flake) - Bump go to 1.20.14 ([#​6736](https://togithub.com/cert-manager/cert-manager/issues/6736), [@​jetstack-bot](https://togithub.com/jetstack-bot)) - Cert-manager is now built with Go 1.20.12 ([#​6544](https://togithub.com/cert-manager/cert-manager/issues/6544), [@​wallrj](https://togithub.com/wallrj)) - Cert-manager is now built with Go 1.20.13 ([#​6630](https://togithub.com/cert-manager/cert-manager/issues/6630), [@​SgtCoDFish](https://togithub.com/SgtCoDFish)) - Fix CVE 2023 48795 by upgrading to golang.org/x/crypto@v0.17.0 ([#​6675](https://togithub.com/cert-manager/cert-manager/issues/6675), [@​wallrj](https://togithub.com/wallrj)) - Fix GHSA-7ww5-4wqc-m92c by upgrading to `github.com/containerd/containerd@v1.7.12` ([#​6684](https://togithub.com/cert-manager/cert-manager/issues/6684), [@​wallrj](https://togithub.com/wallrj)) ### [`v1.13.3`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.3) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.13.2...v1.13.3) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. >⚠️ Read about the [**breaking changes in cert-manager 1.13**](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.0) before you upgrade from a < v1.13 version! This patch release contains fixes for the following security vulnerabilities in the cert-manager-controller: - [`GO-2023-2334`](https://pkg.go.dev/vuln/GO-2023-2334): Decryption of malicious PBES2 JWE objects can consume unbounded system resources. If you use [ArtifactHub Security report](https://artifacthub.io/packages/helm/cert-manager/cert-manager/1.13.2?modal=security-report) or [trivy](https://trivy.dev/), this patch will also silence the following warning about a vulnerability in code which is imported but **not used** by the cert-manager-controller: - [`CVE-2023-47108`](https://access.redhat.com/security/cve/CVE-2023-47108): DoS vulnerability in `otelgrpc` due to unbound cardinality metrics. An ongoing security audit of cert-manager suggested some changes to the webhook code to mitigate DoS attacks, and these are included in this patch release. ##### Changes ##### Bug or Regression - The webhook server now returns HTTP error 413 (Content Too Large) for requests with body size `>= 3MiB`. This is to mitigate DoS attacks that attempt to crash the webhook process by sending large requests that exceed the available memory. ([#​6507](https://togithub.com/cert-manager/cert-manager/pull/6507), [@​inteon](https://togithub.com/inteon)) - The webhook server now returns HTTP error 400 (Bad Request) if the request contains an empty body. ([#​6507](https://togithub.com/cert-manager/cert-manager/pull/6507), [@​inteon](https://togithub.com/inteon)) - The webhook server now returns HTTP error 500 (Internal Server Error) rather than crashing, if the code panics while handling a request. ([#​6507](https://togithub.com/cert-manager/cert-manager/pull/6507), [@​inteon](https://togithub.com/inteon)) - Mitigate potential "Slowloris" attacks by setting `ReadHeaderTimeout` in all `http.Server` instances. ([#​6538](https://togithub.com/cert-manager/cert-manager/pull/6538), [@​wallrj](https://togithub.com/wallrj)) - Upgrade Go modules: `otel`, `docker`, and `jose` to fix CVE alerts. See GHSA-8pgv-569h-w5rw, GHSA-jq35-85cj-fj4p, and GHSA-2c7c-3mj9-8fqh. ([#​6514](https://togithub.com/cert-manager/cert-manager/pull/6514), [@​inteon](https://togithub.com/inteon)) ##### Dependencies ##### Added *Nothing has changed.* ##### Changed - `cloud.google.com/go/firestore`: `v1.11.0 → v1.12.0` - `cloud.google.com/go`: `v0.110.6 → v0.110.7` - `github.com/felixge/httpsnoop`: [`v1.0.3 → v1.0.4`](https://togithub.com/felixge/httpsnoop/compare/v1.0.3...v1.0.4) - `github.com/go-jose/go-jose/v3`: [`v3.0.0 → v3.0.1`](https://togithub.com/go-jose/go-jose/v3/compare/v3.0.0...v3.0.1) - `github.com/go-logr/logr`: [`v1.2.4 → v1.3.0`](https://togithub.com/go-logr/logr/compare/v1.2.4...v1.3.0) - `github.com/golang/glog`: [`v1.1.0 → v1.1.2`](https://togithub.com/golang/glog/compare/v1.1.0...v1.1.2) - `github.com/google/go-cmp`: [`v0.5.9 → v0.6.0`](https://togithub.com/google/go-cmp/compare/v0.5.9...v0.6.0) - `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`: `v0.45.0 → v0.46.0` - `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp`: `v0.44.0 → v0.46.0` - `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`: `v1.19.0 → v1.20.0` - `go.opentelemetry.io/otel/exporters/otlp/otlptrace`: `v1.19.0 → v1.20.0` - `go.opentelemetry.io/otel/metric`: `v1.19.0 → v1.20.0` - `go.opentelemetry.io/otel/sdk`: `v1.19.0 → v1.20.0` - `go.opentelemetry.io/otel/trace`: `v1.19.0 → v1.20.0` - `go.opentelemetry.io/otel`: `v1.19.0 → v1.20.0` - `go.uber.org/goleak`: `v1.2.1 → v1.3.0` - `golang.org/x/sys`: `v0.13.0 → v0.14.0` - `google.golang.org/genproto/googleapis/api`: `f966b18 → b8732ec` - `google.golang.org/genproto`: `f966b18 → b8732ec` - `google.golang.org/grpc`: `v1.58.3 → v1.59.0` ##### Removed *Nothing has changed.* ### [`v1.13.2`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.2) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.13.1...v1.13.2) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. v1.13.2 fixes some CVE alerts and contains fixes for: 1. a CertificateRequest runaway situation in case two Certificate resources point to the same Secret target resource 2. a small bug in the Helm chart (feature gate options) 3. a Venafi issuer bug #####⚠️ READ https://github.com/cert-manager/cert-manager/releases/tag/v1.13.0 before you upgrade from a < v1.13 version! ##### Changes since v1.13.1 ##### Bug or Regression - Bump golang.org/x/net v0.15.0 => v0.17.0 as part of addressing CVE-2023-44487 / CVE-2023-39325 ([#​6432](https://togithub.com/cert-manager/cert-manager/issues/6432), [@​SgtCoDFish](https://togithub.com/SgtCoDFish)) - BUGFIX\[helm]: Fix issue where webhook feature gates were only set if controller feature gates are set. ([#​6381](https://togithub.com/cert-manager/cert-manager/issues/6381), [@​asapekia](https://togithub.com/asapekia)) - Fix runaway bug caused by multiple Certificate resources that point to the same Secret resource. ([#​6425](https://togithub.com/cert-manager/cert-manager/issues/6425), [@​inteon](https://togithub.com/inteon)) - The Venafi issuer now properly resets the certificate and should no longer get stuck with `WebSDK CertRequest Module Requested Certificate` or `This certificate cannot be processed while it is in an error state. Fix any errors, and then click Retry.`. ([#​6402](https://togithub.com/cert-manager/cert-manager/issues/6402), [@​maelvls](https://togithub.com/maelvls)) ##### Other (Cleanup or Flake) - Bump go to 1.20.10 to address CVE-2023-39325. Also bumps base images. ([#​6411](https://togithub.com/cert-manager/cert-manager/issues/6411), [@​SgtCoDFish](https://togithub.com/SgtCoDFish)) ### [`v1.13.1`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.1) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.13.0...v1.13.1) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. v1.13.1 contains a bugfix for a name collision bug in the StableCertificateRequestName feature that was enabled by default in v1.13.0. #####⚠️ READ https://github.com/cert-manager/cert-manager/releases/tag/v1.13.0 before you upgrade from a < v1.13 version! #### Changes since v1.13.0 ##### Bug or Regression - BUGFIX: fix CertificateRequest name collision bug in StableCertificateRequestName feature. ([#​6358](https://togithub.com/cert-manager/cert-manager/issues/6358), [@​jetstack-bot](https://togithub.com/jetstack-bot)) ##### Other (Cleanup or Flake) - Upgrade `github.com/emicklei/go-restful/v3` to `v3.11.0` because `v3.10.2` is labeled as "DO NOT USE". ([#​6368](https://togithub.com/cert-manager/cert-manager/issues/6368), [@​inteon](https://togithub.com/inteon)) - Upgrade Go from 1.20.7 to 1.20.8. ([#​6370](https://togithub.com/cert-manager/cert-manager/issues/6370), [@​jetstack-bot](https://togithub.com/jetstack-bot)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/lambchop4prez/network). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
dco-signoff: yes
Indicates that all commits in the pull request have the valid DCO sign-off message.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
Indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6816
/assign inteon