Fix error message string substitutions #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String.prototype.replace() had some extra undesireable substitution behaviour when it replaces a tag with a string containing some internal tags like `$$`, or `$'`. For more detailed information see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace#Specifying_a_string_as_a_parameter
|
Great work @jurko-gospodnetic 😄 |
keithamus
added a commit
that referenced
this pull request
Dec 14, 2015
…ng-substitutions Fix error message string substitutions
This was referenced Jan 31, 2016
This was referenced Feb 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #560.
Tests included.
I noticed the
getMessagetests currently seem to be missing severalgetMessage()implementation features (e.g. how different objects get serialized to strings), but I did not go into implementing those here.