Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message string substitutions #570

Merged
merged 2 commits into from
Dec 14, 2015
Merged

Fix error message string substitutions #570

merged 2 commits into from
Dec 14, 2015

Commits on Dec 14, 2015

  1. split up getMessage() tests

    @jurko-gospodnetic
    jurko-gospodnetic committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    f73d026 View commit details
    Browse the repository at this point in the history

  2. fix error message tag substitution 

    String.prototype.replace() had some extra undesireable substitution behaviour
when it replaces a tag with a string containing some internal tags like `$$`,
or `$'`.

For more detailed information see:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace#Specifying_a_string_as_a_parameter
    @jurko-gospodnetic
    jurko-gospodnetic committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    568fc1a View commit details
    Browse the repository at this point in the history