Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with none releases ending up as snapshot releases #706

Merged
merged 6 commits into from Feb 16, 2022

Conversation

Andarist
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2021

馃 Changeset detected

Latest commit: 3e9d7e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@changesets/assemble-release-plan Patch
@changesets/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 13, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3e9d7e8:

Sandbox Source
Vanilla Configuration

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing me, the tests seem to be about ignored packages but the title sounds like it's about changesets with none releases?

@Andarist
Copy link
Member Author

Andarist commented Jan 10, 2022

This is confusing me, the tests seem to be about ignored packages but the title sounds like it's about changesets with none releases?

That is cause updating a dependency of an ignored package ends up being a none release for that ignored package - so it doesn't get released but we can adjust its dependency ranges. This reflects the actual use case which got me to fix this.

There might be also a more basic test case to be written here though - I didn't evaluate it. The fixed bug is about a situation in which Changesets itself creates a none release for a package on behalf of the user. Can this happen in any other situation? I agree though that maybe the changeset description should be adjusted here

@Andarist
Copy link
Member Author

@mitchellhamilton I've tweaked the changeset and the test title, I've also added a new test case for a situation with explicit none release type. Could you re-review it?

@Andarist Andarist merged commit 0812858 into main Feb 16, 2022
@Andarist Andarist deleted the fix/ignored-pkgs-snapshot-releases branch February 16, 2022 11:14
@github-actions github-actions bot mentioned this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants