Fixed an issue with none releases ending up as snapshot releases

.changeset/calm-eggs-wonder.md

@@ -0,0 +1,6 @@
+---
+"@changesets/assemble-release-plan": patch
+"@changesets/cli": patch
+---
+
+Fixed an issue with `"none"` releases causing package versions being bumped during snapshot releases. In addition to when you create `"none"` release types explicitly Changesets might create them implicitly in some situations, for example under some circumstances this issue caused snapshot releases to be created sometimes for ignored packages.

packages/assemble-release-plan/src/index.ts

@@ -42,6 +42,9 @@ function getNewVersion(
   snapshotSuffix: string | undefined,
   useCalculatedVersionForSnapshots: boolean
 ): string {
+  if (release.type === "none") {
+    return release.oldVersion;
+  }
   /**
    * Using version as 0.0.0 so that it does not hinder with other version release
    * For example;

packages/cli/src/commands/version/version.test.ts

@@ -191,19 +191,28 @@ describe("running version in a simple project", () => {
 
   it("should not bump ignored packages", async () => {
     await writeChangesets([simpleChangeset, simpleChangeset3], cwd);
-    const spy = jest.spyOn(fs, "writeFile");
 
     await version(cwd, defaultOptions, {
       ...modifiedDefaultConfig,
       ignore: ["pkg-a"]
     });
 
-    expect(getPkgJSON("pkg-b", spy.mock.calls)).toEqual(
-      expect.objectContaining({ name: "pkg-b", version: "1.0.1" })
-    );
-    expect(getPkgJSON("pkg-a", spy.mock.calls)).toEqual(
-      expect.objectContaining({ name: "pkg-a", version: "1.0.0" })
-    );
+    expect((await getPackages(cwd)).packages.map(x => x.packageJson))
+      .toMatchInlineSnapshot(`
+      Array [
+        Object {
+          "dependencies": Object {
+            "pkg-b": "1.0.1",
+          },
+          "name": "pkg-a",
+          "version": "1.0.0",
+        },
+        Object {
+          "name": "pkg-b",
+          "version": "1.0.1",
+        },
+      ]
+    `);
   });
 
   it("should not commit the result if commit config is not set", async () => {
@@ -516,6 +525,93 @@ describe("snapshot release", () => {
     expect(spy).not.toHaveBeenCalled();
   });
 
+  it("should not bump version of a package with an explicit none release type", async () => {
+    const cwd = await f.copy("simple-project");
+    await writeChangeset(
+      {
+        releases: [{ name: "pkg-a", type: "none" }],
+        summary: "some internal stuff"
+      },
+      cwd
+    );
+
+    await version(
+      cwd,
+      {
+        snapshot: true
+      },
+      modifiedDefaultConfig
+    );
+
+    expect((await getPackages(cwd)).packages.map(x => x.packageJson))
+      .toMatchInlineSnapshot(`
+      Array [
+        Object {
+          "dependencies": Object {
+            "pkg-b": "1.0.0",
+          },
+          "name": "pkg-a",
+          "version": "1.0.0",
+        },
+        Object {
+          "name": "pkg-b",
+          "version": "1.0.0",
+        },
+      ]
+    `);
+  });
+
+  it("should not bump version of an ignored package when its dependency gets updated", async () => {
+    const originalDate = Date;
+    // eslint-disable-next-line no-global-assign
+    Date = class Date {
+      toISOString() {
+        return "2021-12-13T00:07:30.879Z";
+      }
+    } as any;
+    try {
+      const cwd = await f.copy("simple-project");
+      await writeChangeset(
+        {
+          releases: [{ name: "pkg-b", type: "major" }],
+          summary: "a very useful summary"
+        },
+        cwd
+      );
+
+      await version(
+        cwd,
+        {
+          snapshot: true
+        },
+        {
+          ...modifiedDefaultConfig,
+          ignore: ["pkg-a"]
+        }
+      );
+
+      expect((await getPackages(cwd)).packages.map(x => x.packageJson))
+        .toMatchInlineSnapshot(`
+        Array [
+          Object {
+            "dependencies": Object {
+              "pkg-b": "0.0.0-20211213000730",
+            },
+            "name": "pkg-a",
+            "version": "1.0.0",
+          },
+          Object {
+            "name": "pkg-b",
+            "version": "0.0.0-20211213000730",
+          },
+        ]
+      `);
+    } finally {
+      // eslint-disable-next-line no-global-assign
+      Date = originalDate;
+    }
+  });
+
   describe("useCalculatedVersionForSnapshots: true", () => {
     it("should update packages using calculated version", async () => {
       let cwd = f.copy("simple-project");
@@ -549,6 +645,103 @@ describe("snapshot release", () => {
         })
       );
     });
+
+    it("should not bump version of a package with an explicit none release type", async () => {
+      const cwd = await f.copy("simple-project");
+      await writeChangeset(
+        {
+          releases: [{ name: "pkg-a", type: "none" }],
+          summary: "some internal stuff"
+        },
+        cwd
+      );
+
+      await version(
+        cwd,
+        {
+          snapshot: true
+        },
+        {
+          ...modifiedDefaultConfig,
+          ___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH: {
+            ...modifiedDefaultConfig.___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH,
+            useCalculatedVersionForSnapshots: true
+          }
+        }
+      );
+
+      expect((await getPackages(cwd)).packages.map(x => x.packageJson))
+        .toMatchInlineSnapshot(`
+        Array [
+          Object {
+            "dependencies": Object {
+              "pkg-b": "1.0.0",
+            },
+            "name": "pkg-a",
+            "version": "1.0.0",
+          },
+          Object {
+            "name": "pkg-b",
+            "version": "1.0.0",
+          },
+        ]
+      `);
+    });
+
+    it("should not bump version of an ignored package when its dependency gets updated", async () => {
+      const originalDate = Date;
+      // eslint-disable-next-line no-global-assign
+      Date = class Date {
+        toISOString() {
+          return "2021-12-13T00:07:30.879Z";
+        }
+      } as any;
+      try {
+        const cwd = await f.copy("simple-project");
+        await writeChangeset(
+          {
+            releases: [{ name: "pkg-b", type: "major" }],
+            summary: "a very useful summary"
+          },
+          cwd
+        );
+
+        await version(
+          cwd,
+          {
+            snapshot: true
+          },
+          {
+            ...modifiedDefaultConfig,
+            ignore: ["pkg-a"],
+            ___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH: {
+              ...modifiedDefaultConfig.___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH,
+              useCalculatedVersionForSnapshots: true
+            }
+          }
+        );
+
+        expect((await getPackages(cwd)).packages.map(x => x.packageJson))
+          .toMatchInlineSnapshot(`
+          Array [
+            Object {
+              "dependencies": Object {
+                "pkg-b": "2.0.0-20211213000730",
+              },
+              "name": "pkg-a",
+              "version": "1.0.0",
+            },
+            Object {
+              "name": "pkg-b",
+              "version": "2.0.0-20211213000730",
+            },
+          ]
+        `);
+      } finally {
+        // eslint-disable-next-line no-global-assign
+        Date = originalDate;
+      }
+    });
   });
 });