Fixed an issue with incorrect dependent updates on none changesets with updateInternalDependents: "always"

__fixtures__/simplest-transitive-devdependent/.changeset/README.md

@@ -0,0 +1,3 @@
+# We just want a file in here so git collects it
+
+For this we have deliberately not included a config file, as we want to test the defaults

__fixtures__/simplest-transitive-devdependent/package.json

@@ -0,0 +1,11 @@
+{
+  "private": true,
+  "name": "simple-project",
+  "description": "three projects, each depending on one other",
+  "version": "1.0.0",
+  "bolt": {
+    "workspaces": [
+      "packages/*"
+    ]
+  }
+}

__fixtures__/simplest-transitive-devdependent/packages/pkg-a/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "pkg-a",
+  "version": "1.0.0"
+}

__fixtures__/simplest-transitive-devdependent/packages/pkg-b/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "pkg-b",
+  "version": "1.0.0",
+  "devDependencies": { "pkg-a": "1.0.0" }
+}

__fixtures__/simplest-transitive-devdependent/packages/pkg-c/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "pkg-c",
+  "version": "1.0.0",
+  "dependencies": { "pkg-b": "1.0.0" }
+}

packages/assemble-release-plan/src/index.test.ts

@@ -1387,6 +1387,31 @@ describe("bumping peerDeps", () => {
       expect(releases[2].name).toEqual("pkg-c");
       expect(releases[2].newVersion).toEqual("1.0.1");
     });
+
+    it("should not bump a transitive dependent when a devDependency package gets bumped", () => {
+      setup.addPackage("pkg-c", "1.0.0");
+      setup.updateDevDependency("pkg-b", "pkg-a", "^1.0.0");
+      setup.updateDependency("pkg-c", "pkg-b", "^1.0.0");
+
+      let { releases } = assembleReleasePlan(
+        setup.changesets,
+        setup.packages,
+        {
+          ...defaultConfig,
+          ___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH: {
+            ...defaultConfig.___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH,
+            updateInternalDependents: "always",
+          },
+        },
+        undefined
+      );
+
+      expect(releases.length).toBe(2);
+      expect(releases[0].name).toEqual("pkg-a");
+      expect(releases[0].newVersion).toEqual("1.0.1");
+      expect(releases[1].name).toEqual("pkg-b");
+      expect(releases[1].newVersion).toEqual("1.0.0");
+    });
   });
 
   it("should major bump dependent when leaving range", () => {

packages/cli/src/commands/version/version.test.ts

@@ -1066,6 +1066,59 @@ describe("updateInternalDependents: always", () => {
       "
     `);
   });
+
+  it("should not bump a devDependency or any of its dependants when a dependency package gets bumped", async () => {
+    const cwd = await f.copy("simplest-transitive-devdependent");
+    const spy = jest.spyOn(fs, "writeFile");
+    await writeChangeset(simpleChangeset, cwd);
+    await version(cwd, defaultOptions, {
+      ...modifiedDefaultConfig,
+      ___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH: {
+        ...defaultConfig.___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH,
+        updateInternalDependents: "always",
+      },
+    });
+
+    expect(getPkgJSON("pkg-a", spy.mock.calls)).toEqual(
+      expect.objectContaining({
+        name: "pkg-a",
+        version: "1.1.0",
+      })
+    );
+    expect(getPkgJSON("pkg-b", spy.mock.calls)).toEqual(
+      expect.objectContaining({
+        name: "pkg-b",
+        version: "1.0.0",
+        devDependencies: {
+          "pkg-a": "1.1.0",
+        },
+      })
+    );
+    expect(getPkgJSON("pkg-c", spy.mock.calls)).toEqual(
+      expect.objectContaining({
+        name: "pkg-c",
+        version: "1.0.0",
+        dependencies: {
+          "pkg-b": "1.0.0",
+        },
+      })
+    );
+    expect(getChangelog("pkg-a", spy.mock.calls)).toMatchInlineSnapshot(`
+      "# pkg-a
+
+      ## 1.1.0
+
+      ### Minor Changes
+
+      - g1th4sh: This is a summary
+      "
+    `);
+
+    // pkg-b and - pkg-c are not being released so changelogs should not be
+    // generated for them
+    expect(() => getChangelog("pkg-b", spy.mock.calls)).toThrowError();
+    expect(() => getChangelog("pkg-c", spy.mock.calls)).toThrowError();
+  });
 });
 
 describe("pre", () => {