Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: ignore microsoft within markdown link check #3363

Merged
merged 2 commits into from Jun 15, 2022
Merged

ci: ignore microsoft within markdown link check #3363

merged 2 commits into from Jun 15, 2022

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Jun 15, 2022

Signed-off-by: STRRL im@strrl.dev

What problem does this PR solve?

"markdown-link-check" usually failed because of https://www.microsoft.com/ in the last several weeks, I think it might relate to the robot access policy of MS.

But we have no other way except ignore that error.

  • try to fix CI "markdown-link-check" failed with https://www.microsoft.com/

I have created an issue gaurav-nelson/github-action-markdown-link-check#140 on upstream.

What's changed and how it works?

  • ignore https://www.microsoft.com/ with CI markdown-link-check

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.2
    • release-2.1

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note 

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@STRRL
ci: ignore microsoft within markdown link check
7df79ee 
Signed-off-by: STRRL <im@strrl.dev>
@STRRL STRRL added the no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR label Jun 15, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 15, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from Yiyiyimu June 15, 2022 07:46
@STRRL
Copy link
Member Author

STRRL commented Jun 15, 2022

/cc @YangKeao @g1eny0ung @Hexilee @Andrewmatilde

YangKeao
YangKeao approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g1eny0ung
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5b6d21e

@YangKeao
Copy link
Member

YangKeao commented Jun 15, 2022 •
edited

It seems that there are more and more websites are giving us 0...

@ti-chi-bot ti-chi-bot merged commit 55210d2 into chaos-mesh:master Jun 15, 2022
@ti-srebot ti-srebot mentioned this pull request Jun 15, 2022
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #3366

@ti-srebot ti-srebot mentioned this pull request Jun 15, 2022
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.2 in PR #3367

ti-chi-bot pushed a commit that referenced this pull request Jun 16, 2022
@ti-srebot @STRRL
ci: ignore microsoft within markdown link check (#3363) (#3367)
5b9469f 
Signed-off-by: STRRL <im@strrl.dev>

Co-authored-by: STRRL <im@strrl.dev>
ti-chi-bot pushed a commit that referenced this pull request Jun 16, 2022
@ti-srebot @STRRL
ci: ignore microsoft within markdown link check (#3363) (#3366)
65e6448 
Signed-off-by: STRRL <im@strrl.dev>

Co-authored-by: STRRL <im@strrl.dev>
stephen-harris pushed a commit to stephen-harris/chaos-mesh that referenced this pull request Jun 23, 2022
@STRRL @g1eny0ung @stephen-harris
ci: ignore microsoft within markdown link check (chaos-mesh#3363)
064b2ae 
Signed-off-by: STRRL <im@strrl.dev>

Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@g1eny0ung g1eny0ung g1eny0ung approved these changes

@Yiyiyimu Yiyiyimu Awaiting requested review from Yiyiyimu

@Andrewmatilde Andrewmatilde Awaiting requested review from Andrewmatilde

@Hexilee Hexilee Awaiting requested review from Hexilee

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.1 needs-cherry-pick-release-2.2 no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR size/XS status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@STRRL @ti-chi-bot @g1eny0ung @YangKeao @ti-srebot