Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ignore microsoft within markdown link check (#3363) #3366

Merged

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 15, 2022

cherry-pick #3363 to release-2.1
You can switch your code base to this Pull Request by using git-extras:

# In chaos-mesh repo:
git pr https://github.com/chaos-mesh/chaos-mesh/pull/3366

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/chaos-mesh.git pr/3366:release-2.1-55210d25c67f

Signed-off-by: STRRL im@strrl.dev

What problem does this PR solve?

"markdown-link-check" usually failed because of https://www.microsoft.com/ in the last several weeks, I think it might relate to the robot access policy of MS.

But we have no other way except ignore that error.

  • try to fix CI "markdown-link-check" failed with https://www.microsoft.com/

I have created an issue gaurav-nelson/github-action-markdown-link-check#140 on upstream.

What's changed and how it works?

  • ignore https://www.microsoft.com/ with CI markdown-link-check

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.2
    • release-2.1

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: STRRL <im@strrl.dev>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 15, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@STRRL
Copy link
Member

STRRL commented Jun 16, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 58b8c88

@ti-chi-bot ti-chi-bot merged commit 65e6448 into chaos-mesh:release-2.1 Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants