Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that args are saved inside of the throttled helper #10942

Merged
merged 3 commits into from Dec 10, 2022
Merged

Ensure that args are saved inside of the throttled helper #10942

merged 3 commits into from Dec 10, 2022

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Dec 5, 2022

May resolve #10935

@etimberg etimberg added this to the Version 4.2 milestone Dec 5, 2022
@etimberg etimberg requested a review from kurkle December 5, 2022 23:43
@etimberg etimberg mentioned this pull request Dec 5, 2022
Closed
LeeLenaleee
LeeLenaleee previously approved these changes Dec 6, 2022
View reviewed changes
@abaksha-sc
Copy link

It will not solve the issue:
#10935 (comment)

kurkle
kurkle previously approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not related, but should the "ticking = false" be after the function call?

@etimberg
Copy link
Member Author

etimberg commented Dec 7, 2022

Not sure; if the function errors out it wouldn't be callable again because ticking would still be true

@etimberg etimberg merged commit b491554 into chartjs:master Dec 10, 2022
@kurkle kurkle mentioned this pull request Dec 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangreen dangreen dangreen left review comments

@kurkle kurkle kurkle approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee left review comments

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 4.1.0
Development

Successfully merging this pull request may close these issues.

Wrong chart size when using throttled
5 participants
@etimberg @abaksha-sc @dangreen @kurkle @LeeLenaleee