Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that args are saved inside of the throttled helper #10942

Merged
merged 3 commits into from Dec 10, 2022
Merged

Ensure that args are saved inside of the throttled helper #10942

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a50529
Ensure that args are saved inside of the throttled helper
etimberg Dec 5, 2022
521b7ef
Capture args in outer scope
etimberg Dec 6, 2022
b8333aa
Simplify capture
etimberg Dec 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/helpers/helpers.extras.ts
View file
Open in desktop
Expand Up @@ -27,14 +27,17 @@ export function throttled<TArgs extends Array<any>>(
fn: (...args: TArgs) => void,
thisArg: any,
) {
let argsToUse = [] as TArgs;
let ticking = false;

return function(...args: TArgs) {
// Save the args for use later
argsToUse = Array.from(args) as TArgs;
etimberg marked this conversation as resolved.
Show resolved Hide resolved
if (!ticking) {
ticking = true;
requestAnimFrame.call(window, () => {
ticking = false;
fn.apply(thisArg, args);
fn.apply(thisArg, argsToUse);
});
}
};
Expand Down