lower z index of scale border so it draws behind the chart elements again #9412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
reviewed
Jul 14, 2021
src/core/core.scale.js
Outdated
| @@ -1599,8 +1599,8 @@ export default class Scale extends Element { | |||
| _layers() { | |||
| const me = this; | |||
| const opts = me.options; | |||
| const tz = opts.ticks && opts.ticks.z || 0; | |||
| const gz = opts.grid && opts.grid.z || 0; | |||
| const tz = opts.ticks && opts.ticks.z || -1; | |||
There was a problem hiding this comment.
Should use valueOrDefault, because you can't define z as 0 now. Does the tick z need to be changed?
There was a problem hiding this comment.
The test wont fail if it isnt changed, but I thought since they where at the same z-index it would be logic to keep them at the same z-index
kurkle
previously approved these changes
Jul 14, 2021
etimberg
previously approved these changes
Jul 15, 2021
|
I think this needs a rebase for the CI to work. |
|
Could also use a regression test |
* Fix the title positions for center positioned axes * Handle center position for vertical axes * Tests
…apancies with scale borderColor
…enaleee/Chart.js into fix/axis-line-behind-bubble
|
It seems my knowledge on how to do a rebase is not good enough because it tries to merge existing commits into the master again, should I open a new clean pr to avoid issues or will this one be fine? |
|
@LeeLenaleee I do the following when rebasing: git checkout master
git pull upstream master
# only needed if your master bransh has some extra commits you need to get rid of
# git reset --hard upstream/master
git checkout <pr branch>
git rebase master
git push -f |
|
Closing in favour of #9426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comming from #8936 resolves #9411
Since this was the behaviour in V2 and before v3.2 It should be considered a breaking change that the border of a scale draws above the chart elements by default, so it should be delayed to v4
https://codepen.io/leelenaleee/pen/ExmZXPa